After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691746 - Revamp the initialization sequence and move things around
Revamp the initialization sequence and move things around
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 691744
Blocks:
 
 
Reported: 2013-01-14 22:39 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-05-20 17:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
main: Remove isWindowActorDisplayedOnWorkspace (3.65 KB, patch)
2013-01-14 22:39 UTC, Jasper St. Pierre (not reading bugmail)
accepted-commit_now Details | Review
main: Move getWindowActorsForWorkspace to layout (2.10 KB, patch)
2013-01-14 22:40 UTC, Jasper St. Pierre (not reading bugmail)
reviewed Details | Review
main: Move WindowAttentionManager into WindowManager (9.15 KB, patch)
2013-01-14 22:40 UTC, Jasper St. Pierre (not reading bugmail)
rejected Details | Review
main: Move workspace tracking code to WindowManager (17.50 KB, patch)
2013-01-14 22:40 UTC, Jasper St. Pierre (not reading bugmail)
reviewed Details | Review
main: Override the workspace layout in WindowManager (1.42 KB, patch)
2013-01-14 22:40 UTC, Jasper St. Pierre (not reading bugmail)
accepted-commit_now Details | Review
main: Remove isWindowActorDisplayedOnWorkspace (3.83 KB, patch)
2013-01-18 20:37 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
main: Move getWindowActorsForWorkspace to layout (1.84 KB, patch)
2013-01-18 20:38 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
main: Initialize WindowAttentionHandler in WindowManager (2.48 KB, patch)
2013-01-18 20:38 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
main: Move workspace tracking code to WindowManager (17.53 KB, patch)
2013-01-18 20:38 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
main: Override the workspace layout in WindowManager (1.45 KB, patch)
2013-01-18 20:38 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
main: Move workspace tracking code to WindowManager (17.60 KB, patch)
2013-05-18 20:24 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
main: Override the workspace layout in WindowManager (1.41 KB, patch)
2013-05-18 20:25 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-01-14 22:39:56 UTC
This is a WIP branch I have that will hopefully free gdm
from needing mutter at all, and hopefully make parts of
the shell codebase more standalone, and able to be tested
with the compositor.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-14 22:39:59 UTC
Created attachment 233475 [details] [review]
main: Remove isWindowActorDisplayedOnWorkspace

We now have a convenience method in mutter.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-01-14 22:40:01 UTC
Created attachment 233476 [details] [review]
main: Move getWindowActorsForWorkspace to layout

It's only used here.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-14 22:40:04 UTC
Created attachment 233477 [details] [review]
main: Move WindowAttentionManager into WindowManager
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-01-14 22:40:07 UTC
Created attachment 233478 [details] [review]
main: Move workspace tracking code to WindowManager
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-01-14 22:40:09 UTC
Created attachment 233479 [details] [review]
main: Override the workspace layout in WindowManager
Comment 6 Giovanni Campagna 2013-01-18 19:33:36 UTC
Review of attachment 233475 [details] [review]:

Yes (after the API in the dependent bug is settled)
Comment 7 Giovanni Campagna 2013-01-18 19:34:06 UTC
Review of attachment 233476 [details] [review]:

::: js/ui/layout.js
@@ +954,2 @@
     _updateFullscreen: function() {
+        let windows = getWindowActorsForWorkspace(global.screen.get_active_workspace_index());

At this point, make this a method
Comment 8 Giovanni Campagna 2013-01-18 19:37:13 UTC
Review of attachment 233477 [details] [review]:

This buys nothing, and breaks git blame. I would be ok with moving the initialization to window manager, but not the whole module.
Comment 9 Giovanni Campagna 2013-01-18 19:46:55 UTC
Review of attachment 233478 [details] [review]:

Nice!

::: js/ui/windowManager.js
@@ +174,3 @@
+
+        let overrideSettings = new Gio.Settings({ schema: 'org.gnome.shell.overrides' });
+

This gets garbage collected. You need to root it somewhere.

@@ +188,3 @@
+        }
+
+        global.screen.connect('notify::n-workspaces', Lang.bind(this, this._nWorkspacesChanged));

this._workspaces
Comment 10 Giovanni Campagna 2013-01-18 19:48:51 UTC
Review of attachment 233479 [details] [review]:

Ok
Comment 11 Jasper St. Pierre (not reading bugmail) 2013-01-18 20:37:58 UTC
Created attachment 233799 [details] [review]
main: Remove isWindowActorDisplayedOnWorkspace

We now have a convenience method in mutter.
Comment 12 Jasper St. Pierre (not reading bugmail) 2013-01-18 20:38:01 UTC
Created attachment 233800 [details] [review]
main: Move getWindowActorsForWorkspace to layout

It's only used here.
Comment 13 Jasper St. Pierre (not reading bugmail) 2013-01-18 20:38:04 UTC
Created attachment 233801 [details] [review]
main: Initialize WindowAttentionHandler in WindowManager
Comment 14 Jasper St. Pierre (not reading bugmail) 2013-01-18 20:38:07 UTC
Created attachment 233802 [details] [review]
main: Move workspace tracking code to WindowManager
Comment 15 Jasper St. Pierre (not reading bugmail) 2013-01-18 20:38:11 UTC
Created attachment 233803 [details] [review]
main: Override the workspace layout in WindowManager
Comment 16 drago01 2013-02-03 14:39:47 UTC
Review of attachment 233799 [details] [review]:

OK.
Comment 17 drago01 2013-02-03 14:40:36 UTC
Review of attachment 233800 [details] [review]:

OK.
Comment 18 Jasper St. Pierre (not reading bugmail) 2013-02-07 07:18:18 UTC
Attachment 233799 [details] pushed as f738c2b - main: Remove isWindowActorDisplayedOnWorkspace
Attachment 233800 [details] pushed as 5ba0c64 - main: Move getWindowActorsForWorkspace to layout
Comment 19 Jasper St. Pierre (not reading bugmail) 2013-05-18 20:24:37 UTC
Created attachment 244660 [details] [review]
main: Move workspace tracking code to WindowManager
Comment 20 Jasper St. Pierre (not reading bugmail) 2013-05-18 20:25:10 UTC
Created attachment 244661 [details] [review]
main: Override the workspace layout in WindowManager

Rebasing this, as it's going to be helpful to move out of the way for
a focus rework.
Comment 21 Giovanni Campagna 2013-05-20 16:22:21 UTC
Review of attachment 244660 [details] [review]:

Looks good.
Comment 22 Giovanni Campagna 2013-05-20 16:24:28 UTC
Review of attachment 244661 [details] [review]:

Ok
Comment 23 Jasper St. Pierre (not reading bugmail) 2013-05-20 17:20:44 UTC
Attachment 244660 [details] pushed as b2aa29e - main: Move workspace tracking code to WindowManager
Attachment 244661 [details] pushed as 54a9592 - main: Override the workspace layout in WindowManager