After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691731 - messageTray: Remove code for ignoring num lock / scroll lock
messageTray: Remove code for ignoring num lock / scroll lock
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-14 18:51 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-01-18 19:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: Remove code for ignoring num lock / scroll lock (1.09 KB, patch)
2013-01-14 18:51 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-01-14 18:51:12 UTC 
Clutter has gained support for ignoring the num lock and scroll lock
masks, so we don't have to do this anymore.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-14 18:51:14 UTC 
Created attachment 233462 [details] [review]
messageTray: Remove code for ignoring num lock / scroll lock

Clutter now ignores these masks, so we can remove code that depends
on this.
Comment 2 Giovanni Campagna 2013-01-18 19:23:54 UTC 
Review of attachment 233462 [details] [review]:

Please make sure the clutter dependency is updated, I've seen too many downstreams (including our own, gnome-ostree) bitten by an undeclared runtime dep.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-18 19:42:37 UTC 
Attachment 233462 [details] pushed as 42c1285 - messageTray: Remove code for ignoring num lock / scroll lock


Pushed with suggested changes.