GNOME Bugzilla – Bug 691691
Use transformation matrix to rotate touchscreens
Last modified: 2013-07-04 11:28:18 UTC
Instead of using axes swap/axis inversion. The code could be shared with the wacom plugin.
Created attachment 234751 [details] [review] Use CTM I tested with 2.6.4 on Ubuntu 13.04 and the Nexus 7 tablet, but adapted the patch to current git. The Rotate and RotateTo dbus methods work well, but ApplyConfiguration - the one use by the display panel from Control Center does not explicitly call out to rotation so the inputs are not synced in that case on my setup.
Review of attachment 234751 [details] [review]: Please provide a git formatted patch as well, so that authorship is maintained. ::: plugins/xrandr/gsd-xrandr-manager.c @@ +1503,3 @@ struct { GnomeRRRotation rotation; + //Coordinate Transformation Matrix No C++-style comments. @@ +1565,3 @@ gint n_devices; guint i, rot_idx; + Atom float_atom = XInternAtom(GDK_DISPLAY_XDISPLAY(gdk_display_get_default()), "FLOAT", True); assign the value separately from the declaration.
Created attachment 234810 [details] [review] git formatted patch updated based on the comments.
Review of attachment 234810 [details] [review]: Looks good. I would need to test it out before pushing it to master (we don't use Signed-Off-Bys and you should prefix your commit subject with "xrandr: ")
Tested and pushed, thanks.