After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691691 - Use transformation matrix to rotate touchscreens
Use transformation matrix to rotate touchscreens
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: xrandr
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
touch 3.10
Depends on:
Blocks:
 
 
Reported: 2013-01-14 07:33 UTC by Bastien Nocera
Modified: 2013-07-04 11:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use CTM (4.85 KB, patch)
2013-01-29 15:32 UTC, Jani Monoses
needs-work Details | Review
git formatted patch (5.61 KB, patch)
2013-01-30 09:22 UTC, Jani Monoses
committed Details | Review

Description Bastien Nocera 2013-01-14 07:33:52 UTC
Instead of using axes swap/axis inversion.

The code could be shared with the wacom plugin.
Comment 1 Jani Monoses 2013-01-29 15:32:30 UTC
Created attachment 234751 [details] [review]
Use CTM

I tested with 2.6.4 on Ubuntu 13.04 and the Nexus 7 tablet, but adapted the patch to current git.
The Rotate and RotateTo dbus methods work well, but ApplyConfiguration - the one use by the display panel from Control Center does not explicitly call out to rotation so the inputs are not synced in that case on my setup.
Comment 2 Bastien Nocera 2013-01-29 15:39:19 UTC
Review of attachment 234751 [details] [review]:

Please provide a git formatted patch as well, so that authorship is maintained.

::: plugins/xrandr/gsd-xrandr-manager.c
@@ +1503,3 @@
 struct {
         GnomeRRRotation rotation;
+	//Coordinate Transformation Matrix

No C++-style comments.

@@ +1565,3 @@
         gint n_devices;
         guint i, rot_idx;
+        Atom float_atom = XInternAtom(GDK_DISPLAY_XDISPLAY(gdk_display_get_default()), "FLOAT", True);

assign the value separately from the declaration.
Comment 3 Jani Monoses 2013-01-30 09:22:30 UTC
Created attachment 234810 [details] [review]
git formatted patch

updated based on the comments.
Comment 4 Bastien Nocera 2013-01-30 10:02:13 UTC
Review of attachment 234810 [details] [review]:

Looks good. I would need to test it out before pushing it to master

(we don't use Signed-Off-Bys and you should prefix your commit subject with "xrandr: ")
Comment 5 Bastien Nocera 2013-07-04 11:28:11 UTC
Tested and pushed, thanks.