After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691655 - Port to gtkspell3
Port to gtkspell3
Status: RESOLVED FIXED
Product: gtranslator
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: 2.0
Assigned To: gtranslator-maint
gtranslator-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-13 13:32 UTC by Kalev Lember
Modified: 2013-02-03 15:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port to gtkspell3 (2.91 KB, patch)
2013-01-13 13:32 UTC, Kalev Lember 		committed Details | Review
patch to work with Ubuntu pre-released gtkspell (1.66 KB, patch)
2013-02-03 15:32 UTC, Christian Kirbach 		rejected Details | Review

Description Kalev Lember 2013-01-13 13:32:12 UTC 
There's a new GtkSpell release available with gtk3 support. In Fedora the new package is parallel installable with the older GtkSpell and is called gtkspell3  /gtkspell3-devel.
Comment 1 Kalev Lember 2013-01-13 13:32:42 UTC 
Created attachment 233382 [details] [review]
Port to gtkspell3
Comment 2 Ignacio Casal Quinteiro (nacho) 2013-01-13 13:48:28 UTC 
Review of attachment 233382 [details] [review]:

Looks good to me.
Comment 3 Sandro Mani 2013-01-13 14:36:33 UTC 
Review of attachment 233382 [details] [review]:

Looks good to me
Comment 4 Sandro Mani 2013-01-13 14:36:35 UTC 
Review of attachment 233382 [details] [review]:

Looks good to me
Comment 5 Daniel Mustieles 2013-01-13 15:02:25 UTC 
Review of attachment 233382 [details] [review]:

Patch commited, so closing the bug.

Many thanks Kalev for reporting it and creating a patch :)
Comment 6 Christian Kirbach 2013-02-03 11:50:17 UTC 
reopeneing


         PKG_CHECK_MODULES([GTKSPELL], [
-                gtkspell-3.0 >= $GTKSPELL_OPTIONAL
+                gtkspell3-3.0 >= $GTKSPELL_OPTIONAL

this actually does not work on Ubuntu. 

/usr/lib/pkgconfig/gtkspell-3.0.pc

hmm I'd be surprised if the package-config file is called different on Fedora.

I also get compilation errors that I am trying to fix now.
Comment 7 Kalev Lember 2013-02-03 12:28:19 UTC 
Ubuntu is using a prerelease version where the pkgconfig file name differs from the released gtkspell 3.0. Ask them to update to the latest version?
Comment 8 Christian Kirbach 2013-02-03 15:30:58 UTC 
wtf Ubuntu!? Thanks for telling me.

I saw that the gtkspell API docs for the Ubuntu version differ from the official one on the web. hmmm what is gone wrong with Ubuntu?


just for reference, attaching the gtkspell patch that works for me on Ubuntu with the prerelease.
Comment 9 Christian Kirbach 2013-02-03 15:32:30 UTC 
Created attachment 235107 [details] [review]
patch to work with Ubuntu pre-released gtkspell

just for reference