After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691623 - xrandr: Drop an unused object
xrandr: Drop an unused object
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: xrandr
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-12 19:42 UTC by Matthias Clasen
Modified: 2013-01-12 21:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
xrandr: Drop an unused object (1.39 KB, patch)
2013-01-12 19:42 UTC, Matthias Clasen 		none Details | Review
xrandr: Drop an unused object (1.39 KB, patch)
2013-01-12 19:53 UTC, Matthias Clasen 		rejected Details | Review

Description Matthias Clasen 2013-01-12 19:42:30 UTC 
The code was instantiating a GnomePnpIds object, but didn't do
anything with it. Given that this involves parsing the pnp.ids
file, and thus implies IO, get rid of it.
Comment 1 Matthias Clasen 2013-01-12 19:42:32 UTC 
Created attachment 233323 [details] [review]
xrandr: Drop an unused object
Comment 2 Matthias Clasen 2013-01-12 19:53:33 UTC 
Created attachment 233325 [details] [review]
xrandr: Drop an unused object

The code was instantiating a GnomePnpIds object, but didn't do
anything with it. Given that this involves parsing the pnp.ids
file, and thus implies IO, get rid of it.
Comment 3 Bastien Nocera 2013-01-12 20:05:13 UTC 
Actually, it is used.

Might want to add a comment to that effect.

commit c9240e8b69c5833074508b46bc56307aac12ec19
Author: Bastien Nocera <hadess@hadess.net>
Date:   Wed Dec 19 15:31:22 2012 +0100

    xrandr: Avoid the GnomePnpIds object being created multiple times
    
    It's a singleton, but GnomeRR is the only user here, so create
    one before we know it's going to be used multiple times to
    make sure only one instance is created at a time.
Comment 4 Bastien Nocera 2013-01-12 21:17:48 UTC 
Added a comment in master.