After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691592 - the signal handler "gtk_spin_button_accessible_value_changed" should be disconnected
the signal handler "gtk_spin_button_accessible_value_changed" should be disco...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkSpinButton
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-01-12 09:20 UTC by Hiroyuki Ito
Modified: 2013-01-21 03:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a patch for gtkspinbuttonaccessible.c (1.98 KB, patch)
2013-01-12 09:20 UTC, Hiroyuki Ito 		needs-work Details | Review
a patch using g_signal_connect_object (1.44 KB, patch)
2013-01-14 07:25 UTC, Hiroyuki Ito 		accepted-commit_now Details | Review

Description Hiroyuki Ito 2013-01-12 09:20:48 UTC 
Created attachment 233294 [details] [review]
a patch for gtkspinbuttonaccessible.c

An instance of GtkAdjustment may be used by another instance after the spin button widget is destroyed. In that case, the function "gtk_spin_button_accessible_value_changed()" will be called with an invalid argument. This situation is often caused when one use GtkCellRendererSpin widget. To avoid invalid call of the function, the signal handler for the "value-changed" signal should be disconnected when the spin-button widget is destroyed. Attached patch improve the behavior.
Comment 1 Matthias Clasen 2013-01-12 14:42:25 UTC 
Review of attachment 233294 [details] [review]:

We should just use g_signal_connect_object here, I think
Comment 2 Hiroyuki Ito 2013-01-14 07:23:13 UTC 
Thank you for reviewing the patch.

> We should just use g_signal_connect_object here, I think

I tried using g_signal_connect_object. It seems works well.
Comment 3 Hiroyuki Ito 2013-01-14 07:25:29 UTC 
Created attachment 233417 [details] [review]
a patch using g_signal_connect_object
Comment 4 Matthias Clasen 2013-01-20 22:46:53 UTC 
Review of attachment 233417 [details] [review]:

Looks good