After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691559 - Could use a GtkLevelBar subclass for sound level display
Could use a GtkLevelBar subclass for sound level display
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Sound
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Control center sound maintainer(s)
Control-Center Maintainers
3.10
Depends on: 679984
Blocks:
 
 
Reported: 2013-01-11 16:15 UTC by Cosimo Cecchi
Modified: 2021-06-09 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sound: Use a GtkLevelBar and drop our GvcLevelBar (37.47 KB, patch)
2014-12-03 17:18 UTC, Rui Matos
needs-work Details | Review

Description Cosimo Cecchi 2013-01-11 16:15:37 UTC
+++ This bug was initially created as a clone of Bug #679984 +++

It was brought up in bug 679984 that the sound panel could use a GtkLevelBar subclass instead of its own custom widget to display sound levels.

This bug is an enhancement request to track that.
Comment 1 Rui Matos 2014-12-03 17:18:13 UTC
Created attachment 292076 [details] [review]
sound: Use a GtkLevelBar and drop our GvcLevelBar
Comment 2 Bastien Nocera 2015-01-05 12:06:35 UTC
Review of attachment 292076 [details] [review]:

This is a good first start, but the GvcLevelBar had another feature which smoothed the values, instead of just showing them straight away, leading to something that didn't move around so much. See update_peak_value() for example.
Comment 3 Rui Matos 2015-01-06 15:41:52 UTC
(In reply to comment #2)
> This is a good first start, but the GvcLevelBar had another feature which
> smoothed the values, instead of just showing them straight away, leading to
> something that didn't move around so much. See update_peak_value() for example.

The smoothing is still there, that's the part implemented in gvc-mixer-dialog.c:update_input_peak() which doesn't let the value change more than DECAY_STEP at a time when going down.

The part that you're probably refering to is the max peak drawing that would stay for 1 second, but this isn't possible to do with a GtkLevelBar AFAICT.
Comment 4 Bastien Nocera 2015-01-28 11:37:25 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > This is a good first start, but the GvcLevelBar had another feature which
> > smoothed the values, instead of just showing them straight away, leading to
> > something that didn't move around so much. See update_peak_value() for example.
> 
> The smoothing is still there, that's the part implemented in
> gvc-mixer-dialog.c:update_input_peak() which doesn't let the value change more
> than DECAY_STEP at a time when going down.
> 
> The part that you're probably refering to is the max peak drawing that would
> stay for 1 second, but this isn't possible to do with a GtkLevelBar AFAICT.

In which case, it's best not to regress and wait it out.
Comment 5 André Klapper 2021-06-09 16:00:19 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new enhancement request ticket at
  https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/

Thank you for your understanding and your help.