After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691529 - Gnome-shell silently fails to install any extensions
Gnome-shell silently fails to install any extensions
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: extensions
3.6.x
Other Linux
: Normal critical
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 704826 709828 755534 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-01-11 08:40 UTC by Wolfram
Modified: 2021-07-05 14:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libsoup-2-40-requirements-master.patch (1.43 KB, patch)
2013-01-12 08:19 UTC, Priit Laes (IRC: plaes)
none Details | Review

Description Wolfram 2013-01-11 08:40:18 UTC
I've Gnome 3.6 running under Gentoo Linux.

When I'm trying to install extensions from extensions.gnome.org popup appears asking if I'm allow to install. Then I click "Install" button and nothing happens. Gnome just creates empty directory in .local/share/gnome-shell/extensions and extension switch turns to "ON" state - and thats all. When I'm updating extension page switch resets to "OFF" state.

There is no any messages in .xsession-errors or /var/log/gdm/*

I've tried empty HOME but without any success.

Manually installed extensions works.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-11 17:53:06 UTC
Check ~/.cache/gdm/session.log
Comment 2 Wolfram 2013-01-11 18:43:10 UTC
Yeah, I've got error message:

    JS ERROR: !!!   Exception was: TypeError: message.response_body.flatten().get_as_bytes is not a function
    JS ERROR: !!!     message = '"message.response_body.flatten().get_as_bytes is not a function"'
    JS ERROR: !!!     fileName = '"/usr/share/gnome-shell/js/ui/extensionDownloader.js"'
    JS ERROR: !!!     lineNumber = '85'
    JS ERROR: !!!     stack = '"gotExtensionZipFile([object _private_Soup_SessionAsync],[object _private_Soup_Message],"user-theme@gnome-shell-extensions.gcampax.github.com",[object _private_unknown_GLocalFile],callback,errback)@/usr/share/gnome-shell/js/ui/extensionDownloader.js:85
([object _private_Soup_SessionAsync],[object _private_Soup_Message])@/usr/share/gnome-shell/js/ui/extensionDownloader.js:257

But I don't even realize what to do with that. It doesn't look descriptive.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-11 18:55:31 UTC
It seems that you have an outdated libsoup.
Comment 4 Wolfram 2013-01-12 04:54:29 UTC
Ok, I'm going to update to 2.40.2 from 2.38.1 
But I think that gnome-shell should not SILENTLY fail in such case.

Some useful diagnostic message should be given to user.
Comment 5 Wolfram 2013-01-12 05:46:03 UTC
Hooray, updating libsoup to 2.40.2 solved my problem.
Comment 6 Priit Laes (IRC: plaes) 2013-01-12 07:50:32 UTC
I can't really see a reason why this bug was resolved, because in repository the libsoup dependencies are still not fixed. In both 'gnome-3-6' and master branches configure.ac still only looks for 'libsoup-2.4' and doesn't specify minimum version.
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-01-12 08:01:26 UTC
Runtime dependencies aren't specified as built-time dependencies.
Comment 8 Priit Laes (IRC: plaes) 2013-01-12 08:08:14 UTC
(In reply to comment #7)
> Runtime dependencies aren't specified as built-time dependencies.

o_O

When you google for '_private_Soup_SessionAsync' then you can see that this same issue isn't specific to Gentoo, it's a wide-spread issue that can be easily solved by requiring libsoup version that works during build.
Comment 9 Priit Laes (IRC: plaes) 2013-01-12 08:13:20 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > Runtime dependencies aren't specified as built-time dependencies.
> 
> o_O
> 
> When you google for '_private_Soup_SessionAsync' then you can see that this
> same issue isn't specific to Gentoo, it's a wide-spread issue that can be
> easily solved by requiring libsoup version that works during build.

Sorry, I exaggerated a bit, but the issue is that extension downloader uses 'soup_buffer_get_as_bytes' function which is only available since libsoup-2.40.
Comment 10 Priit Laes (IRC: plaes) 2013-01-12 08:19:17 UTC
Created attachment 233293 [details] [review]
libsoup-2-40-requirements-master.patch
Comment 11 Priit Laes (IRC: plaes) 2013-01-12 08:20:52 UTC
(In reply to comment #10)
> Created an attachment (id=233293) [details] [review]
> libsoup-2-40-requirements-master.patch

Same patch applies fine to gnome-3-6 branch with `git am <file>`.
Comment 12 Wolfram 2013-01-12 13:09:47 UTC
Yeah-yeah, also what about descriptive diagnostic message instead of silent error supressing?
Comment 13 Jasper St. Pierre (not reading bugmail) 2013-01-12 16:37:40 UTC
That's waiting on better logging facilities, e.g. the systemd journal. We already return the GError to the page over DBus, and look out for common errors from the page itself, but we haven't added support for that error yet.
Comment 14 Wolfram 2013-01-12 17:12:44 UTC
Why not to introduce "Unknown error, look for the logs" message for all the unhandled and unknown errors?
Comment 15 Jasper St. Pierre (not reading bugmail) 2013-01-12 17:19:14 UTC
You admitted it yourself that the log wasn't something that helped you. In the short term, it might just be easier to require libsoup at build time. We've swung a few ways about buildtime vs. runtime dependencies.
Comment 16 Wolfram 2013-01-12 17:26:31 UTC
But why not just to inform user that something went wrong?

Not supress error?
Comment 17 Florian Müllner 2015-09-24 11:43:50 UTC
*** Bug 704826 has been marked as a duplicate of this bug. ***
Comment 18 Florian Müllner 2015-09-24 11:44:01 UTC
*** Bug 709828 has been marked as a duplicate of this bug. ***
Comment 19 Florian Müllner 2015-09-24 11:44:10 UTC
*** Bug 755534 has been marked as a duplicate of this bug. ***
Comment 20 Florian Müllner 2017-11-25 06:30:16 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab-test.gnome.org/fmuellner/gnome-shell-extensions/issues/96.
Comment 21 Florian Müllner 2017-11-25 08:44:49 UTC
Sorry for the noise, I "found" a bug in the migration script:
https://gitlab.gnome.org/External/bugzilla-to-gitlab-migrator/issues/2
Comment 22 GNOME Infrastructure Team 2021-07-05 14:21:06 UTC
GNOME is going to shut down bugzilla.gnome.org in favor of  gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/

Thank you for your understanding and your help.