GNOME Bugzilla – Bug 691505
egg-armor: Fix memrchr() call with negative string length
Last modified: 2019-02-22 11:59:33 UTC
I could not reproduce this issue reliably as is, but Karsten pointed me to a variant of this bug that could be reproduced easily: gnome-keyring import ~/.ssh/id_rsa See https://bugzilla.redhat.com/show_bug.cgi?id=893162 --- egg/egg-armor.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
Created attachment 233191 [details] [review] 0001-egg-armor-Fix-memrchr-call-with-negative-string-leng.patch
Dupe of bug 691500 ?
Matthias, this is the same issue in two places.
Created attachment 233363 [details] [review] egg-armor: Fix memrchr() call with negative string length * Initial patch by Gustavo Luiz Duarte <gustavold@linux.vnet.ibm.com> * The cause of this bug was reusing argument variables for other purposes in parsing functions when that didn't really make sense, so fix this as well. * Add tests that catch this issue. See https://bugzilla.redhat.com/show_bug.cgi?id=893162
For distributors back-porting this fix: The original patch is an adequate and minimal fix for the issue.