After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691505 - egg-armor: Fix memrchr() call with negative string length
egg-armor: Fix memrchr() call with negative string length
Status: RESOLVED FIXED
Product: gcr
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-01-10 22:14 UTC by Colin Walters
Modified: 2019-02-22 11:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-egg-armor-Fix-memrchr-call-with-negative-string-leng.patch (1.24 KB, patch)
2013-01-10 22:14 UTC, Colin Walters
none Details | Review
egg-armor: Fix memrchr() call with negative string length (7.70 KB, patch)
2013-01-13 08:41 UTC, Stef Walter
committed Details | Review

Description Colin Walters 2013-01-10 22:14:00 UTC
I could not reproduce this issue reliably as is, but Karsten pointed
me to a variant of this bug that could be reproduced easily:
gnome-keyring import ~/.ssh/id_rsa

See https://bugzilla.redhat.com/show_bug.cgi?id=893162
---
 egg/egg-armor.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Comment 1 Colin Walters 2013-01-10 22:14:31 UTC
Created attachment 233191 [details] [review]
0001-egg-armor-Fix-memrchr-call-with-negative-string-leng.patch
Comment 2 Matthias Clasen 2013-01-12 21:46:53 UTC
Dupe of bug 691500 ?
Comment 3 Stef Walter 2013-01-13 08:23:27 UTC
Matthias, this is the same issue in two places.
Comment 4 Stef Walter 2013-01-13 08:41:29 UTC
Created attachment 233363 [details] [review]
egg-armor: Fix memrchr() call with negative string length

 * Initial patch by Gustavo Luiz Duarte <gustavold@linux.vnet.ibm.com>
 * The cause of this bug was reusing argument variables for other
   purposes in parsing functions when that didn't really make sense,
   so fix this as well.
 * Add tests that catch this issue.

See https://bugzilla.redhat.com/show_bug.cgi?id=893162
Comment 5 Stef Walter 2013-01-13 08:42:35 UTC
For distributors back-porting this fix: The original patch is an adequate and minimal fix for the issue.