After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691469 - UOA: use the new libaccounts-glib APIs
UOA: use the new libaccounts-glib APIs
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: UOA
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-10 11:23 UTC by Mardy
Modified: 2013-01-11 12:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
UOA: Use the new libaccounts-glib APIs (7.14 KB, patch)
2013-01-10 11:24 UTC, Mardy 		reviewed Details | Review
UOA: Use the new libaccounts-glib APIs (7.18 KB, patch)
2013-01-11 11:59 UTC, Mardy 		committed Details | Review

Description Mardy 2013-01-10 11:23:14 UTC 
The 1.4 release of libaccounts-glib introduces new APIs based on GVariant and GAsyncResult, while the current ones are deprecated.
Comment 1 Mardy 2013-01-10 11:24:26 UTC 
Created attachment 233147 [details] [review]
UOA: Use the new libaccounts-glib APIs

The APIs based on GValue are now deprecated.
Comment 2 Mardy 2013-01-10 11:25:38 UTC 
Note that libaccounts-glib 1.4 is not packaged for Ubuntu yet. I recommend to wait a few days before merging this.
Comment 3 Mardy 2013-01-11 08:38:17 UTC 
(In reply to comment #2)
> Note that libaccounts-glib 1.4 is not packaged for Ubuntu yet. I recommend to
> wait a few days before merging this.

It's out :-) So, reviews are welcome :-)
Comment 4 Guillaume Desmottes 2013-01-11 09:47:29 UTC 
Review of attachment 233147 [details] [review]:

Looks pretty good. Feel free to merge once you have fixed this small niptick.

::: ubuntu-online-accounts/mc-plugin/mcp-account-manager-uoa.c
@@ +177,1 @@
   if (error != NULL)

We usually use if (!____finish())
Comment 5 Mardy 2013-01-11 11:59:16 UTC 
Created attachment 233219 [details] [review]
UOA: Use the new libaccounts-glib APIs

The APIs based on GValue are now deprecated.
Comment 6 Guillaume Desmottes 2013-01-11 12:06:13 UTC 
Review of attachment 233219 [details] [review]:

++

thanks for the patch!
Comment 7 David King 2013-01-11 12:18:35 UTC 
Comment on attachment 233219 [details] [review]
UOA: Use the new libaccounts-glib APIs

Pushed to master as commit 02db084adde59fc94129ebd7ea5c2c24fad7c07a.