After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691463 - libcaribou: avoid integer overflow
libcaribou: avoid integer overflow
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other All
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-10 09:29 UTC by Daiki Ueno
Modified: 2013-01-11 02:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libcaribou: avoid integer overflow (2.26 KB, patch)
2013-01-10 09:29 UTC, Daiki Ueno 		committed Details | Review

Description Daiki Ueno 2013-01-10 09:29:13 UTC 
See patch.  I'll push this soon, since it is an obvious fix.
Comment 1 Daiki Ueno 2013-01-10 09:29:15 UTC 
Created attachment 233142 [details] [review]
libcaribou: avoid integer overflow

Since Xkb.Desc.{min,max}_keycode and Xkb.SymMap.width are defined
as uchar, for-loops over with uchar index may not stop, if the upper
bound is uchar.MAX.
Comment 2 Daiki Ueno 2013-01-11 02:49:47 UTC 
Attachment 233142 [details] pushed as 4fd5713 - libcaribou: avoid integer overflow