After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691424 - WnckWindow should emit a signal when the window class changes
WnckWindow should emit a signal when the window class changes
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: libwnck maintainers
libwnck maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-09 14:26 UTC by Marco Trevisan (Treviño)
Modified: 2013-02-05 20:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Window: emit class-changed signal when the instance or group class name changes (2.97 KB, patch)
2013-01-09 14:26 UTC, Marco Trevisan (Treviño) 		none Details | Review
TestWnck: monitor window class changes as well (2.97 KB, patch)
2013-01-09 14:27 UTC, Marco Trevisan (Treviño) 		accepted-commit_now Details | Review
Window: emit class-changed signal when the instance or group class name changes (5.10 KB, patch)
2013-01-09 14:42 UTC, Marco Trevisan (Treviño) 		accepted-commit_now Details | Review

Description Marco Trevisan (Treviño) 2013-01-09 14:26:42 UTC 
Created attachment 233078 [details] [review]
Window: emit class-changed signal when the instance or group class name changes

In some windows (such as libreoffice) the WM_CLASS value changes, so we need a way to get a notification when this happen to make the proper application matching at shell level.

This is needed by BAMF (used by Unity and other docks)
Comment 1 Marco Trevisan (Treviño) 2013-01-09 14:27:09 UTC 
Created attachment 233079 [details] [review]
TestWnck: monitor window class changes as well
Comment 2 Vincent Untz 2013-01-09 14:39:54 UTC 
First patch is not the right one, it seems :-)
Comment 3 Marco Trevisan (Treviño) 2013-01-09 14:42:08 UTC 
Created attachment 233081 [details] [review]
Window: emit class-changed signal when the instance or group class name changes
Comment 4 Marco Trevisan (Treviño) 2013-02-05 18:05:56 UTC 
Review of attachment 233081 [details] [review]:

+1
Comment 5 Marco Trevisan (Treviño) 2013-02-05 18:07:04 UTC 
Review of attachment 233079 [details] [review]:

+1