After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691392 - Add input purpose and hints to StEntry and StIMText
Add input purpose and hints to StEntry and StIMText
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: st
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 700043
 
 
Reported: 2013-01-09 10:14 UTC by Daiki Ueno
Modified: 2013-05-10 05:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
st-im-text: remove undefined st_im_text_set_autoshow_im decl (784 bytes, patch)
2013-01-09 10:14 UTC, Daiki Ueno 		committed Details | Review
st-im-text: add input purpose and hints (7.11 KB, patch)
2013-01-09 10:14 UTC, Daiki Ueno 		committed Details | Review
st-entry: add input purpose and hints (7.36 KB, patch)
2013-01-09 10:14 UTC, Daiki Ueno 		committed Details | Review

Description Daiki Ueno 2013-01-09 10:14:03 UTC 
It might be useful if "input-purpose" and "input-hints" properties can be set on StEntry, like GtkEntry.  Particularly to disable IM on lock screen:

Bug 891835 - gnome-shell screensaver should disable input methods for password input 
https://bugzilla.redhat.com/show_bug.cgi?id=891835
Comment 1 Daiki Ueno 2013-01-09 10:14:06 UTC 
Created attachment 233049 [details] [review]
st-im-text: remove undefined st_im_text_set_autoshow_im decl
Comment 2 Daiki Ueno 2013-01-09 10:14:09 UTC 
Created attachment 233050 [details] [review]
st-im-text: add input purpose and hints

Add input-purpose and input-hints properties to StIMText,
and pass these on to GtkIMContext.
Comment 3 Daiki Ueno 2013-01-09 10:14:12 UTC 
Created attachment 233051 [details] [review]
st-entry: add input purpose and hints

Add input-purpose and input-hints properties to StEntry,
and pass these on to StIMText.
Comment 4 Rui Matos 2013-05-09 19:47:50 UTC 
Review of attachment 233049 [details] [review]:

Yes
Comment 5 Rui Matos 2013-05-10 01:58:10 UTC 
Review of attachment 233050 [details] [review]:

Fine
Comment 6 Rui Matos 2013-05-10 01:58:31 UTC 
Review of attachment 233051 [details] [review]:

Looks good, thanks for the patches!
Comment 7 Rui Matos 2013-05-10 01:58:45 UTC 
Review of attachment 233050 [details] [review]:

Fine
Comment 8 Daiki Ueno 2013-05-10 05:37:26 UTC 
Attachment 233049 [details] pushed as 6fac33e - st-im-text: remove undefined st_im_text_set_autoshow_im decl
Attachment 233050 [details] pushed as bb04091 - st-im-text: add input purpose and hints
Attachment 233051 [details] pushed as 08599af - st-entry: add input purpose and hints