After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691316 - no minimum size set
no minimum size set
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
3.10
: 712258 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-01-07 22:17 UTC by William Jon McCann
Modified: 2018-01-18 18:37 UTC
See Also:
GNOME target: 3.10
GNOME version: ---

Attachments
screenshot (45.70 KB, image/png)
2013-01-07 22:17 UTC, William Jon McCann 		  Details
Use native gobject requests (1.13 KB, patch)
2013-01-27 23:52 UTC, Pierre-Yves Luyten 		reviewed Details | Review
main-window: Set minimum size (1.20 KB, patch)
2013-08-14 12:56 UTC, Debarshi Ray 		committed Details | Review

Description William Jon McCann 2013-01-07 22:17:24 UTC 
Created attachment 232945 [details]
screenshot

There is no minimum size.
Comment 1 Pierre-Yves Luyten 2013-01-27 23:52:41 UTC 
Created attachment 234570 [details] [review]
Use native gobject requests

This patch requests 600 per 500
Comment 2 Debarshi Ray 2013-08-14 12:53:29 UTC 
Review of attachment 234570 [details] [review]:

You are missing the bugzilla URL in the commit message.

::: src/photos-main-window.c
@@ +39,3 @@
 
+#define PHOTOS_WINDOW_MIN_WIDTH 600
+#define PHOTOS_WINDOW_MIN_HEIGHT 500

Even though these are the values used by gnome-documents, our thumbnails are bigger and hence this leaves a big corridor of empty space on the right.

Lets use 640x600. This accommodates two columns nicely, and the height is the same as the default dimensions -- 960x600.
Comment 3 Debarshi Ray 2013-08-14 12:56:05 UTC 
Created attachment 251611 [details] [review]
main-window: Set minimum size
Comment 4 Debarshi Ray 2018-01-18 18:37:28 UTC 
*** Bug 712258 has been marked as a duplicate of this bug. ***