GNOME Bugzilla – Bug 691265
Hang when changing password if new password is old password
Last modified: 2013-07-08 03:14:42 UTC
GNOME Control Center hangs when changing a user's password if the new password is the same as the old password. See http://git.gnome.org/browse/gnome-control-center/tree/panels/user-accounts/um-password-dialog.c?h=gnome-3-6#n243 We need a new conditional there: else if (strcmp (password, old_password) == 0)
Created attachment 233616 [details] [review] don't hang when calling passwd A longer tooltip might be more clear. This one was selected because it's already localized.
Does the patch look OK? The underlying problem is that passwd gives another prompt when new password equals old password (at least on openSUSE) which gnome-control-center does not expect: michael@linux-14l9:~> passwd Changing password for michael. Old Password: New Password: You must choose a new password. New Password: You must choose a new password. New Password: Seems simplest to avoid this in gnome-control-center by making sure the password is actually changed.
Actually, this is now kind of redundant with the recently-submitted pwquality changes as it should now reject passwords if they're the same as they were before. (Still would be more robust to include the check, though.)
(In reply to comment #3) > Actually, this is now kind of redundant with the recently-submitted pwquality > changes as it should now reject passwords if they're the same as they were > before. (Still would be more robust to include the check, though.) It's just not possible to trigger this anymore for this reason.