GNOME Bugzilla – Bug 691167
Build failure: key-file tests built before dependencies
Last modified: 2013-01-06 01:43:54 UTC
Created attachment 232803 [details] [review] Fix the ordering of test build directories In master, if I make check, I run into: make[3]: *** No rule to make target `../../tests/lib/key-file/libkf-test.la', needed by `individual-retrieval'. Stop. make[3]: *** Waiting for unfinished jobs.... VALAC individual_retrieval_vala.stamp error: Package `folks-test' not found in specified Vala API directories or GObject-Introspection GIR directories error: Package `kf-test' not found in specified Vala API directories or GObject-Introspection GIR directories Compilation failed: 2 error(s), 0 warning(s) make[3]: *** [individual_retrieval_vala.stamp] Error 1 make[3]: Leaving directory `/home/treitter/collabora/folks/tests/key-file' make[2]: *** [all-recursive] Error 1 make[2]: *** Waiting for unfinished jobs.... ============= This seems to be a simple regression introduced by 96c51fe585b which broke build dependencies.
Review of attachment 232803 [details] [review]: Might be an idea to put a comment before SUBDIRS saying that ‘lib’ and ‘data’ need to be listed first, otherwise I’ll probably make the same mistake again sometime. Also needs a NEWS entry.
Review comments addressed and pushed ==================================== commit 81d2d6730eb47ab2b87bdd2138a378aac9f853a1 Author: Travis Reitter <travis.reitter@collabora.co.uk> Date: Fri Jan 4 18:02:15 2013 -0800 Bug 691167 — Build failure: key-file tests built before dependencies This fixes a regression from 96c51fe585b which built the key-file tests before the libraries they depended upon (breaking the build). Closes: https://bugzilla.gnome.org/show_bug.cgi?id=691167 NEWS | 1 + tests/Makefile.am | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-)