After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691117 - shmsink perms get only a copy and past of set
shmsink perms get only a copy and past of set
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-04 10:10 UTC by Levente Farkas
Modified: 2013-01-04 20:48 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Levente Farkas 2013-01-04 10:10:32 UTC
in gstshmsink.c in the gst_shm_sink_get_property (line ~267) the
case PROP_PERMS:
not get but set the perms which is obviously bad. the strange thing that all other properties properly get-ed and not set. imho it'd have to be a simple line:
g_value_set_uint (value, self->perms);

it's also bad in 0.10 and 1.0 branch.
Comment 1 Olivier Crête 2013-01-04 20:40:21 UTC
Oops, fixed!

commit 4caad2d06cb9f2114b1ef9ec76052534160fa80e
Author: Olivier Crête <olivier.crete@collabora.com>
Date:   Fri Jan 4 15:38:58 2013 -0500

    shm: Actually get the permissions on get_property
Comment 2 Olivier Crête 2013-01-04 20:43:44 UTC
Also in 0.10:

commit f980a4de1df95962d133ba1bbfb9ab5fa706483e
Author: Olivier Crête <olivier.crete@collabora.com>
Date:   Fri Jan 4 15:38:58 2013 -0500

    shm: Actually get the permissions on get_property
Comment 3 Levente Farkas 2013-01-04 20:48:29 UTC
dare i ask for a solution for https://bugzilla.gnome.org/show_bug.cgi?id=682775 too:-)?