After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691096 - g_signal_lookup gives too many warnings
g_signal_lookup gives too many warnings
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: gobject
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-01-03 22:10 UTC by Torsten Schoenfeld
Modified: 2018-05-24 14:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Torsten Schoenfeld 2013-01-03 22:10:01 UTC 
g_signal_lookup has some code that provides elaborate warnings in case no signal was found:

http://git.gnome.org/browse/glib/tree/gobject/gsignal.c#n1203

I think this code is overzealous; the second and the third warning blocks don't seem to be warranted.

• There are interfaces with signals (e.g., GtkCellEditable), so it must be legal to try to look up a signal in an interface.  The if (!G_TYPE_IS_INSTANTIATABLE (itype)) warning is therefore incorrect, I think.

• It seems to be perfectly legal to try to look up a signal in a type in its class' class_init function, when the type hasn't been fully loaded yet.  The results also seem to be completely correct.  So the if (!g_type_class_peek (itype)) warning also seems to be incorrect.

Should I submit a patch that removes these warnings?
Comment 1 GNOME Infrastructure Team 2018-05-24 14:55:24 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/650.