After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691090 - sourceview: Add marks to an unloaded document the same way we reload marks.
sourceview: Add marks to an unloaded document the same way we reload marks.
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: plugins: editor: gtksourceview
unspecified
Other All
: Normal normal
: ---
Assigned To: Johannes Schmid
Anjuta maintainers
: 690676 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-01-03 20:01 UTC by Carl-Anton Ingmarsson
Modified: 2013-01-04 10:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sourceview: Add marks to an unloaded document the same way we reload marks. (7.61 KB, patch)
2013-01-03 20:01 UTC, Carl-Anton Ingmarsson 		accepted-commit_now Details | Review

Description Carl-Anton Ingmarsson 2013-01-03 20:01:45 UTC 
See attached patch.
Comment 1 Carl-Anton Ingmarsson 2013-01-03 20:01:47 UTC 
Created attachment 232662 [details] [review]
sourceview: Add marks to an unloaded document the same way we reload marks.

Instead of using a lot of idle sources we can instead use the existing code for reloading marks
to add the new mark when the document is loaded. This fixes a problem where the added
idles would starve all other mainloop sources with a lower priority than
G_PRIORITY_DEFAULT_IDLE.

For example this would cause the loading of documents to completely fail when using GLib
from git since the async read in sourceview-io.c uses G_PRIORITY_LOW. Previous versions
of GLib would complete the asynchronous task using an idle with G_PRIORITY_DEFAULT
regardless of the passed in priority. GLib from git instead completes the task using a idle
with the passed in priority so the idle sources for adding marks now starves the completion of
the asynchronous read.
Comment 2 Johannes Schmid 2013-01-03 23:34:44 UTC 
Review of attachment 232662 [details] [review]:

Looks good to me - thanks!

It's sometimes interesting what the glib developers see as ABI stability...

Could be related to #690676 in some way.
Comment 3 Johannes Schmid 2013-01-03 23:37:21 UTC 
*** Bug 690676 has been marked as a duplicate of this bug. ***