After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691025 - add crosses as markers
add crosses as markers
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Charting
git master
Other Linux
: Normal normal
: ---
Assigned To: Jean Bréfort
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2013-01-02 17:27 UTC by Frédéric Parrenin
Modified: 2015-04-01 15:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (8.23 KB, image/png)
2013-01-02 18:54 UTC, Andreas J. Guelzow
  Details
Proposed patch (6.75 KB, patch)
2015-03-31 18:26 UTC, Jean Bréfort
committed Details | Review

Description Frédéric Parrenin 2013-01-02 17:27:22 UTC
Currently, there is no cross marker symbol available.
Comment 1 Jean Bréfort 2013-01-02 17:32:33 UTC
We do have, just they are not very visible with the default marker background settings (look at the third row in the marker chooser)
Comment 2 Frédéric Parrenin 2013-01-02 18:15:24 UTC
There is a bug here on my Ubuntu 12.10 system.
The first three symbols of the third row appear like squares.
Comment 3 Jean Bréfort 2013-01-02 18:50:09 UTC
Not sure you have a bug. Choose a white or, preferably a transparent background for the marker.
Comment 4 Andreas J. Guelzow 2013-01-02 18:54:26 UTC
Created attachment 232554 [details]
screenshot

I assume Frederic sees the same as I do  and which is shown in the attached screenshot. Note that the "squares" in the third row have some small dots in the centres of each side .
Comment 5 Andreas J. Guelzow 2013-01-02 18:57:04 UTC
Jean, I gather that when you say 'background' you mean 'fill'. THere is something strange going on with the filling. I think this is a bug.
Comment 6 Jean Bréfort 2013-01-02 19:02:41 UTC
What is strange? It alsways worked this way, and is excel compatible as far as I remember how excel behaves.
Comment 7 Andreas J. Guelzow 2013-01-07 16:28:43 UTC
I think that having a "fill" that colours areas outside of the stroked boundary of the crosses can be classified as strange. Nevertheless you are correct in that Excel's fill behaves the same way.

There is one significant difference in Excel though: when I create a scatterplot in Excel the marker fill is set to "automatic" which results in no fill for crosses and a solid fill for the squares, etc. So the crosses are very clearly visible.
Comment 8 Jean Bréfort 2013-01-07 17:03:17 UTC
When the marker is automatic, and with both default and guppi theme, the fill color is set to transparent. Not when editing the style though.
Create a new empty plot with four series, and look at the marker style for the fourth series.

Now is this a bug or a feature?
Comment 9 Andreas J. Guelzow 2013-01-09 16:45:27 UTC
I guess the difference is that Excel has a fill colour that is "automatic", while Gnumeric sets the fill colour automatically when creating the graph but once it is set it is a fixed colour (that can be changed).
Comment 10 Jean Bréfort 2015-03-31 13:58:15 UTC
It probably makes sense to change the auto-fill behavior for unclosed markers (cross, x, and asterisk), so that it is always transparent whatever the theme.
Comment 11 Jean Bréfort 2015-03-31 18:26:04 UTC
Created attachment 300698 [details] [review]
Proposed patch

Can anybody test this patch?
Comment 12 Frédéric Parrenin 2015-04-01 08:45:19 UTC
I tested it and it works for me.
The automatic filling is transparent for empty markers and has the same colour than the outline for non-empty markers.
Two remarks:
- I still find it a bit strange to allow filling for empty markers. Not sure we should mimic this stupid XL behavior
- I can't find a way to set the fill colour to transparent. Is this possible right now?
Comment 13 Jean Bréfort 2015-04-01 09:32:44 UTC
1. It's better to be excel compatible when possible
2. Yes, using the custom color button.

Anyway, my patch is not enough. The selected fill color should be transparent in the selector too, otherwise it is not possible to use the non transparent default color (a very minor issue anyway, but it makes sense to reflect the actual color in the selector).
Comment 14 Jean Bréfort 2015-04-01 12:31:43 UTC
Hmm, looks that that patch is the best that can be done without changing the whole thing, so I'll go for it.
Comment 15 Jean Bréfort 2015-04-01 15:26:23 UTC
Review of attachment 300698 [details] [review]:

Patch applied.
Comment 16 Jean Bréfort 2015-04-01 15:27:03 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.