After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 691019 - Don't use the texture cache for search results
Don't use the texture cache for search results
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-02 16:06 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-01-02 17:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
remoteSearch: Use GIcon for loading icon data (2.00 KB, patch)
2013-01-02 16:10 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
st-texture-cache: Remove st_texture_cache_load_from_raw (3.15 KB, patch)
2013-01-02 16:10 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-01-02 16:06:43 UTC 
This results in a memory leak of sorts.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-01-02 16:10:20 UTC 
Created attachment 232532 [details] [review]
remoteSearch: Use GIcon for loading icon data

This removes us from caching the pixbuf data in the icon cache,
and allows us to remove St.TextureCache.load_from_raw().
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-01-02 16:10:23 UTC 
Created attachment 232533 [details] [review]
st-texture-cache: Remove st_texture_cache_load_from_raw

This is now unused.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-01-02 16:13:19 UTC 
Note that the removal of load_from_raw depends on #680414
Comment 4 Giovanni Campagna 2013-01-02 17:05:38 UTC 
Review of attachment 232532 [details] [review]:

Yes.
Comment 5 Giovanni Campagna 2013-01-02 17:18:55 UTC 
Review of attachment 232533 [details] [review]:

Yes!

(Although it is sad that now we rescale pixbufs in software inside GtkIconTheme...)
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-01-02 17:34:09 UTC 
Attachment 232532 [details] pushed as 4288761 - remoteSearch: Use GIcon for loading icon data
Attachment 232533 [details] pushed as 4b095d5 - st-texture-cache: Remove st_texture_cache_load_from_raw