After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690974 - Fix build with srcdir != builddir
Fix build with srcdir != builddir
Status: RESOLVED FIXED
Product: baobab
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Baobab Maintainers
Baobab Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-01-02 01:56 UTC by Giovanni Campagna
Modified: 2013-07-20 10:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix srcdir != builddir (1.54 KB, patch)
2013-01-02 01:56 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2013-01-02 01:56:27 UTC
.
Comment 1 Giovanni Campagna 2013-01-02 01:56:55 UTC
Created attachment 232494 [details] [review]
Fix srcdir != builddir

Includes an update of libgd to current master for a similar fix.

Depends on bug 690972 for the libgd update.
Comment 2 Paolo Borelli 2013-01-02 10:06:51 UTC
Review of attachment 232494 [details] [review]:

Thank you Giovanni. Patch looks mostly good to me except for a nitpick/question below... Feel free to push once the libgd one is committed

::: src/Makefile.am
@@ -47,3 @@
 	$(BUILT_SOURCES)
 
-baobab-resources.c: baobab.gresource.xml $(shell $(GLIB_COMPILE_RESOURCES) --generate-dependencies baobab.gresource.xml)

can't we use --sourcedir=$(srcdir) also for the generate-dependecies command instead?
Comment 3 Giovanni Campagna 2013-01-02 17:28:07 UTC
Attachment 232494 [details] pushed as 1f2a72e - Fix srcdir != builddir
Comment 4 Paolo Borelli 2013-01-05 16:49:32 UTC
Baobab cannot check out the libgd submodule anymore... maybe the hash you committed to baobab is not the one that was committed in the libgd repo?



fatal: reference is not a tree: 1de58d47f4e28e3c2b19402e54ecab1dd6f749fd
Unable to checkout '1de58d47f4e28e3c2b19402e54ecab1dd6f749fd' in submodule path 'libgd'
*** Error during phase checkout of baobab: ########## Error running git submodule update *** [1/26]
Comment 5 Giovanni Campagna 2013-01-05 16:59:52 UTC
Indeed, by mistake I used git bz in libgd, which rebased the commit. The right hash is 680a9f72a0c3019cf4013ed026270ee7b9f1abc9.
Comment 6 Paolo Borelli 2013-01-13 20:14:15 UTC
Giovanni: I updated to the right submodule version and that fixes the build, but distcheck fails with

error: unable to open `../../libgd/gd-1.0.vapi' for writing

So for now I reverted to a previuos version of libgd.
Comment 7 Stefano Facchini 2013-07-20 10:43:51 UTC
not using libgd anymore