GNOME Bugzilla – Bug 690974
Fix build with srcdir != builddir
Last modified: 2013-07-20 10:43:51 UTC
.
Created attachment 232494 [details] [review] Fix srcdir != builddir Includes an update of libgd to current master for a similar fix. Depends on bug 690972 for the libgd update.
Review of attachment 232494 [details] [review]: Thank you Giovanni. Patch looks mostly good to me except for a nitpick/question below... Feel free to push once the libgd one is committed ::: src/Makefile.am @@ -47,3 @@ $(BUILT_SOURCES) -baobab-resources.c: baobab.gresource.xml $(shell $(GLIB_COMPILE_RESOURCES) --generate-dependencies baobab.gresource.xml) can't we use --sourcedir=$(srcdir) also for the generate-dependecies command instead?
Attachment 232494 [details] pushed as 1f2a72e - Fix srcdir != builddir
Baobab cannot check out the libgd submodule anymore... maybe the hash you committed to baobab is not the one that was committed in the libgd repo? fatal: reference is not a tree: 1de58d47f4e28e3c2b19402e54ecab1dd6f749fd Unable to checkout '1de58d47f4e28e3c2b19402e54ecab1dd6f749fd' in submodule path 'libgd' *** Error during phase checkout of baobab: ########## Error running git submodule update *** [1/26]
Indeed, by mistake I used git bz in libgd, which rebased the commit. The right hash is 680a9f72a0c3019cf4013ed026270ee7b9f1abc9.
Giovanni: I updated to the right submodule version and that fixes the build, but distcheck fails with error: unable to open `../../libgd/gd-1.0.vapi' for writing So for now I reverted to a previuos version of libgd.
not using libgd anymore