After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690973 - Fix build with srcdir != builddir
Fix build with srcdir != builddir
Status: RESOLVED FIXED
Product: gnome-dictionary
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-dictionary-maint
gnome-dictionary-maint
Depends on:
Blocks:
 
 
Reported: 2013-01-02 01:54 UTC by Giovanni Campagna
Modified: 2013-01-02 17:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix build with srcdir != builddir (2.47 KB, patch)
2013-01-02 01:55 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-01-02 01:54:45 UTC 
.
Comment 1 Giovanni Campagna 2013-01-02 01:55:02 UTC 
Created attachment 232493 [details] [review]
Fix build with srcdir != builddir

- $(srcdir) is relative to $(builddir), so you must not cd before using it.
- src/ needs to reference libgdict include paths, or it cannot find
  gdict-enum-types.h, which is not in the same directory as gdict.h
Comment 2 Emmanuele Bassi (:ebassi) 2013-01-02 12:07:19 UTC 
Review of attachment 232493 [details] [review]:

looks good
Comment 3 Giovanni Campagna 2013-01-02 17:32:34 UTC 
Attachment 232493 [details] pushed as eaacf80 - Fix build with srcdir != builddir