GNOME Bugzilla – Bug 690965
shell crashes when requesting tray while displaying message
Last modified: 2013-01-02 17:33:59 UTC
Requesting the tray while a message is being displayed, then discarding the message by clicking the balloon in the message tray causes gnome-shell to crash. Steps to reproduce: 1. run "notify-send foo" in a shell 2. hit Win-M to display tray *during display of message* 3. wait for tray to appear 4. click notification icon 5. click message bubble 6. gnome-shell crashes (alt-tab behaves erroneously, "alt-f2 r" doesn't work..) Waiting for the message to disappear and opening the tray after that does not seem to produce the bug. related bugs https://bugzilla.gnome.org/show_bug.cgi?id=682431 https://bugs.archlinux.org/task/32410 https://bugzilla.redhat.com/show_bug.cgi?id=868261 error log is attached
Created attachment 232486 [details] error log
the bug I meant to link to is bug 682433
Created attachment 232526 [details] [review] main: Don't mess up the modal stack when the focus actor is destroyed This seems to be an incorrect conversion when we moved from an array to an object of keys in 3a6b4f3.
Created attachment 232527 [details] [review] main: Rename curFocus to prevFocus This better describes what we're tracking here: the previous keyboard focus before pushing the modal.
Created attachment 232528 [details] [review] main: Add a better comment about shifting the modal stack It took me a few minutes to realize why, so let's just add this in for future reference. Thanks for the extremely clear reproducer! I found the bug.
Review of attachment 232526 [details] [review]: Yes.
Review of attachment 232527 [details] [review]: Ok
Review of attachment 232528 [details] [review]: Ok.
Attachment 232526 [details] pushed as 55aa0cf - main: Don't mess up the modal stack when the focus actor is destroyed Attachment 232527 [details] pushed as 2d9ddd4 - main: Rename curFocus to prevFocus Attachment 232528 [details] pushed as 73388f3 - main: Add a better comment about shifting the modal stack