GNOME Bugzilla – Bug 690960
Misc fixes to gnome-ostree
Last modified: 2013-01-04 00:44:36 UTC
Following on bug 690959, mostly cleanups and modernization.
Created attachment 232475 [details] [review] ostbuild: pick manifest from config if not specified on the command line It is convenient when using ostbuild resolve manually instead of using the autobuilder.
Created attachment 232476 [details] [review] ostbuild: recurse into subdirectories when deleting .la files .la files bring only problems when using shared linking, and should be never installed.
Created attachment 232477 [details] [review] Remove libxklavier and libgnomekbd They're only required by GNOME fallback mode.
Created attachment 232478 [details] [review] Remove gstreamer-0.10 Nothing in GNOME should depend on it anymore.
Created attachment 232479 [details] [review] Reenable GWeather backend for evolution-data-server It was fixed long ago, there is no reason to keep it disabled.
Created attachment 232480 [details] [review] Remove obsolete gnome-shell configure flag gnome-shell hasn't depended on libfolks for a long time, --without-folks has no effect.
Created attachment 232481 [details] [review] Remove gstreamer-0.10 Nothing in GNOME should depend on it anymore.
Created attachment 232482 [details] [review] Remove libgnomekbd It is only required by GNOME fallback mode. Turns out libxklavier is required by caribou...
Review of attachment 232476 [details] [review]: See https://bugzilla.gnome.org/show_bug.cgi?id=690959#c9 Which links to: https://bugzilla.gnome.org/show_bug.cgi?id=654013
Review of attachment 232475 [details] [review]: Looks reasonable.
Review of attachment 232479 [details] [review]: Ok, good.
Review of attachment 232480 [details] [review]: Sounds good.
Review of attachment 232481 [details] [review]: This is the right thing to do now, but long term before removing public API like this we need to know whether it's something applications could be using. Which gets into the open question of what is eternally stable (like glib), what's "slushy", and what is completely unstable (spidermonkey, libgweather for example).
Review of attachment 232482 [details] [review]: Sounds good.
Attachment 232475 [details] pushed as 08059e4 - ostbuild: pick manifest from config if not specified on the command line Attachment 232479 [details] pushed as 561bcb6 - Reenable GWeather backend for evolution-data-server Attachment 232480 [details] pushed as 5cf500e - Remove obsolete gnome-shell configure flag Attachment 232481 [details] pushed as 175829d - Remove gstreamer-0.10 Attachment 232482 [details] pushed as ec61297 - Remove libgnomekbd
Review of attachment 232476 [details] [review]: So I was wrong, let's commit this patch too.
Attachment 232476 [details] pushed as fb70100 - ostbuild: recurse into subdirectories when deleting .la files