After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690960 - Misc fixes to gnome-ostree
Misc fixes to gnome-ostree
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-01-01 23:17 UTC by Giovanni Campagna
Modified: 2013-01-04 00:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ostbuild: pick manifest from config if not specified on the command line (1.59 KB, patch)
2013-01-01 23:17 UTC, Giovanni Campagna
committed Details | Review
ostbuild: recurse into subdirectories when deleting .la files (1.70 KB, patch)
2013-01-01 23:18 UTC, Giovanni Campagna
committed Details | Review
Remove libxklavier and libgnomekbd (898 bytes, patch)
2013-01-01 23:18 UTC, Giovanni Campagna
none Details | Review
Remove gstreamer-0.10 (1.34 KB, patch)
2013-01-01 23:18 UTC, Giovanni Campagna
none Details | Review
Reenable GWeather backend for evolution-data-server (873 bytes, patch)
2013-01-01 23:18 UTC, Giovanni Campagna
committed Details | Review
Remove obsolete gnome-shell configure flag (788 bytes, patch)
2013-01-01 23:18 UTC, Giovanni Campagna
committed Details | Review
Remove gstreamer-0.10 (1.57 KB, patch)
2013-01-01 23:22 UTC, Giovanni Campagna
committed Details | Review
Remove libgnomekbd (751 bytes, patch)
2013-01-01 23:41 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2013-01-01 23:17:21 UTC
Following on bug 690959, mostly cleanups and modernization.
Comment 1 Giovanni Campagna 2013-01-01 23:17:53 UTC
Created attachment 232475 [details] [review]
ostbuild: pick manifest from config if not specified on the command line

It is convenient when using ostbuild resolve manually instead of using
the autobuilder.
Comment 2 Giovanni Campagna 2013-01-01 23:18:07 UTC
Created attachment 232476 [details] [review]
ostbuild: recurse into subdirectories when deleting .la files

.la files bring only problems when using shared linking, and should be never
installed.
Comment 3 Giovanni Campagna 2013-01-01 23:18:18 UTC
Created attachment 232477 [details] [review]
Remove libxklavier and libgnomekbd

They're only required by GNOME fallback mode.
Comment 4 Giovanni Campagna 2013-01-01 23:18:30 UTC
Created attachment 232478 [details] [review]
Remove gstreamer-0.10

Nothing in GNOME should depend on it anymore.
Comment 5 Giovanni Campagna 2013-01-01 23:18:44 UTC
Created attachment 232479 [details] [review]
Reenable GWeather backend for evolution-data-server

It was fixed long ago, there is no reason to keep it disabled.
Comment 6 Giovanni Campagna 2013-01-01 23:18:55 UTC
Created attachment 232480 [details] [review]
Remove obsolete gnome-shell configure flag

gnome-shell hasn't depended on libfolks for a long time, --without-folks
has no effect.
Comment 7 Giovanni Campagna 2013-01-01 23:22:31 UTC
Created attachment 232481 [details] [review]
Remove gstreamer-0.10

Nothing in GNOME should depend on it anymore.
Comment 8 Giovanni Campagna 2013-01-01 23:41:58 UTC
Created attachment 232482 [details] [review]
Remove libgnomekbd

It is only required by GNOME fallback mode.

Turns out libxklavier is required by caribou...
Comment 10 Colin Walters 2013-01-02 19:53:44 UTC
Review of attachment 232475 [details] [review]:

Looks reasonable.
Comment 11 Colin Walters 2013-01-02 19:54:10 UTC
Review of attachment 232479 [details] [review]:

Ok, good.
Comment 12 Colin Walters 2013-01-02 19:54:51 UTC
Review of attachment 232480 [details] [review]:

Sounds good.
Comment 13 Colin Walters 2013-01-02 19:59:00 UTC
Review of attachment 232481 [details] [review]:

This is the right thing to do now, but long term before removing public API like this we need to know whether it's something applications could be using.  Which gets into the open question of what is eternally stable (like glib), what's "slushy", and what is completely unstable (spidermonkey, libgweather for example).
Comment 14 Colin Walters 2013-01-02 19:59:17 UTC
Review of attachment 232482 [details] [review]:

Sounds good.
Comment 15 Giovanni Campagna 2013-01-02 20:13:03 UTC
Attachment 232475 [details] pushed as 08059e4 - ostbuild: pick manifest from config if not specified on the command line
Attachment 232479 [details] pushed as 561bcb6 - Reenable GWeather backend for evolution-data-server
Attachment 232480 [details] pushed as 5cf500e - Remove obsolete gnome-shell configure flag
Attachment 232481 [details] pushed as 175829d - Remove gstreamer-0.10
Attachment 232482 [details] pushed as ec61297 - Remove libgnomekbd
Comment 16 Colin Walters 2013-01-04 00:18:23 UTC
Review of attachment 232476 [details] [review]:

So I was wrong, let's commit this patch too.
Comment 17 Giovanni Campagna 2013-01-04 00:44:32 UTC
Attachment 232476 [details] pushed as fb70100 - ostbuild: recurse into subdirectories when deleting .la files