While I see value in your patch and I'm likely to push it, a more detailed explanation of the encountered build issues would have been appreciated.

Review of attachment 232374 [details] [review]:

Besides the commented lines, it seems obvious there were declared but unused (I thought we already fixed those, weird that some remain) or unfreeed variables. Thanks for the fix, I'll push that right away.

::: src/planner-python-plugin.c
@@ +149,3 @@
 	}
 
+	g_free ((gpointer) dirname);

I'd love to know the warning or error that raised.

::: tests/time-test.c
@@ +24,2 @@
 	/* Test mrp_time_new_from_string */
+	CHECK_STRING_RESULT (mrp_time_to_string (t), "20020331T000000Z");

I'll juste move this before the comment as otherwise it doesn't make sense.

Pushed to master as 596fb7377ec00189cc1f3707602c6a5cc643a1b7 with minor
corrections as explained above. I'm closing this as fixed but don't hesitate to
comment with the explanation asked in comment 2. :-)

(In reply to comment #2)
> Review of attachment 232374 [details] [review]:
> 
> Besides the commented lines, it seems obvious there were declared but unused (I
> thought we already fixed those, weird that some remain) or unfreeed variables.
> Thanks for the fix, I'll push that right away.
> 
> ::: src/planner-python-plugin.c
> @@ +149,3 @@
>      }
> 
> +    g_free ((gpointer) dirname);
> 
> I'd love to know the warning or error that raised.

It was most likely a message from gcc 4.7 about dirname not being a (void *) (not matching g_free prototype. Each gcc release is more and more picky about warnings and with -Werror lots of small things suddendly make the build fail.

> ::: tests/time-test.c
> @@ +24,2 @@
>      /* Test mrp_time_new_from_string */
> +    CHECK_STRING_RESULT (mrp_time_to_string (t), "20020331T000000Z");
> 
> I'll juste move this before the comment as otherwise it doesn't make sense.

ok

Thanks for reviewing and commiting it.