GNOME Bugzilla – Bug 690797
Mark deprecated and inactive keys
Last modified: 2013-01-15 09:43:52 UTC
There are a number of keys that have no effect in a modern GNOME installation, and ignored both by configuration programs and by the session components. We should mark them as legacy to avoid confusing the users with configuration changes that have no effect.
Created attachment 232311 [details] [review] Mark deprecated and inactive keys
Sounds like a good idea to me
Why not just remove them completely?
(In reply to comment #3) > Why not just remove them completely? Uhm, doesn't it break compatibility with older configs or older programs?
Older configs? No. dconf is schemaless, and won't be confused by the lack of schema information. Older programs? When would that happen? The settings here are core GNOME settings, and shouldn't be used elsewhere.
(In reply to comment #5) > Older configs? No. dconf is schemaless, and won't be confused by the lack of > schema information. Uhm, ok. > Older programs? When would that happen? The settings here are core GNOME > settings, and shouldn't be used elsewhere. True, but there are many programs (emacs is one example that comes to my mind) that use org.gnome.desktop.interface directly instead of using GtkSettings, and I would not be surprised if the other schemas are used too. But anyway, I'm ok if you want to simply remove them.
(In reply to comment #6) > True, but there are many programs (emacs is one example that comes to my mind) > that use org.gnome.desktop.interface directly instead of using GtkSettings Link? What does it do on KDE? That sound extremely wrong. XSETTINGS was what this was made for.
Ah, it uses monospace-font-name, which isn't exposed through XSETTINGS.
Review of attachment 232311 [details] [review]: ::: schemas/org.gnome.desktop.background.gschema.xml.in.in @@ +7,3 @@ + Have GNOME draw the desktop background. + + DEPRECATED: This key is deprecated and ignored. Need a bug to remove this from nautilus too? ::: schemas/org.gnome.desktop.default-applications.gschema.xml.in.in @@ +55,3 @@ + + DEPRECATED: This key is deprecated and ignored. + The list of terminal commands is hardcoded in GIO. I'd rather we fixed the glib bug about making this configurable and pointed to the new schema/key combination. ::: schemas/org.gnome.desktop.screensaver.gschema.xml.in.in @@ +25,3 @@ <_summary>Show notifications in the lock screen</_summary> + <_description> + Whether notifications are shown in the lock screen or not. This only affects the standard experience. You can remove the "affects the standard experience" in a separate patch. @@ +58,3 @@ <_summary>Allow logout</_summary> + <_description> + Set this to TRUE to offer an option in the unlock dialog to allow logging out after a delay. The delay is specified in the "logout_delay" key. I believe that some work was done to allow logging out idle sessions after a while. We should clarify which key replaces it. @@ +87,3 @@ + Set this to TRUE to offer an option in the unlock dialog to switch to a different user account. + + DEPRECATED: This key is deprecated and ignored. Should it be ignored? @@ +96,3 @@ + Allow the session status message to be displayed when the screen is locked. + + DEPRECATED: This key is deprecated and ignored. What are session status messages?
(In reply to comment #9) > Review of attachment 232311 [details] [review]: > > ::: schemas/org.gnome.desktop.background.gschema.xml.in.in > @@ +7,3 @@ > + Have GNOME draw the desktop background. > + > + DEPRECATED: This key is deprecated and ignored. > > Need a bug to remove this from nautilus too? It is already removed (it calls the setter but not getter). The important key is show-desktop-icons, not draw-background. > ::: schemas/org.gnome.desktop.default-applications.gschema.xml.in.in > @@ +55,3 @@ > + > + DEPRECATED: This key is deprecated and ignored. > + The list of terminal commands is hardcoded in GIO. > > I'd rather we fixed the glib bug about making this configurable and pointed to > the new schema/key combination. Eh... using GSettings in GIO is going to piss off all DEs that don't ship dconf... > ::: schemas/org.gnome.desktop.screensaver.gschema.xml.in.in > @@ +25,3 @@ > <_summary>Show notifications in the lock screen</_summary> > + <_description> > + Whether notifications are shown in the lock screen or not. This only > affects the standard experience. > > You can remove the "affects the standard experience" in a separate patch. > > @@ +58,3 @@ > <_summary>Allow logout</_summary> > + <_description> > + Set this to TRUE to offer an option in the unlock dialog to allow > logging out after a delay. The delay is specified in the "logout_delay" key. > > I believe that some work was done to allow logging out idle sessions after a > while. We should clarify which key replaces it. I know that gnome-session forces a logout after some idle time, but I don't know which key is used for that. Anyway, this is about giving the option for that, which we always do. > @@ +87,3 @@ > + Set this to TRUE to offer an option in the unlock dialog to switch to > a different user account. > + > + DEPRECATED: This key is deprecated and ignored. > > Should it be ignored? Maybe it should not be - gnome-shell/lock-screen bug in that case. > @@ +96,3 @@ > + Allow the session status message to be displayed when the screen is > locked. > + > + DEPRECATED: This key is deprecated and ignored. > > What are session status messages? There was a button in gnome-screensaver back in the GNOME 2 days, "Write message", which basically posted a notification to be shown once unlocked. I'm not sure, but I think this key refers to that.
I now filed bug 691042 to implement support for user-switch-enabled in gnome-shell.
Fixed after the above changes. I've also marked the terminal bits as being "handled" by GIO, not hardcoded in it. It's an implementation detail. See also https://bugzilla.gnome.org/show_bug.cgi?id=627943 about the terminal handling in GIO.