After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690733 - Assertion when trying to add contacts with only a SIP account connnected
Assertion when trying to add contacts with only a SIP account connnected
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-26 10:57 UTC by Guillaume Desmottes
Modified: 2012-12-26 11:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
roster-window: prevent adding contact if not supported by CM (2.43 KB, patch)
2012-12-26 11:07 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-12-26 10:57:33 UTC 
- Connect only a SIP account
- Try adding a contact

(lt-empathy:8562): folks-CRITICAL **: folks_persona_store_get_can_add_personas: assertion `self != NULL' failed

+ Trace 231320

  • #0 g_logv
    at gmessages.c line 967
  • #1 g_log
    at gmessages.c line 1003
  • #2 g_return_if_fail_warning
    at gmessages.c line 1012
  • #3 folks_persona_store_get_can_add_personas
    at /home/cassidy/gnome/folks/folks/persona-store.vala line 508
  • #4 empathy_connection_can_add_personas
    at empathy-utils.c line 781
  • #5 can_add_contact_to_account
    at empathy-individual-dialogs.c line 67
  • #6 account_chooser_update_iter
    at empathy-account-chooser.c line 894
  • #7 account_chooser_account_add_foreach
    at empathy-account-chooser.c line 742
  • #8 account_manager_prepared_cb
    at empathy-account-chooser.c line 286
  • #9 g_simple_async_result_complete
    at gsimpleasyncresult.c line 777
  • #10 complete_in_idle_cb
    at gsimpleasyncresult.c line 789
  • #11 g_idle_dispatch
    at gmain.c line 4806
  • #12 g_main_dispatch
    at gmain.c line 2715
  • #13 g_main_context_dispatch
    at gmain.c line 3219
  • #14 g_main_context_iterate
    at gmain.c line 3290
  • #15 g_main_context_iteration
    at gmain.c line 3351
  • #16 g_application_run
    at gapplication.c line 1620
  • #17 main
    at empathy.c line 842 






Comment 1


Guillaume Desmottes





          2012-12-26 11:07:09 UTC
        



Created attachment 232234 [details] [review]
roster-window: prevent adding contact if not supported by CM






Comment 2


Xavier Claessens





          2012-12-26 11:12:40 UTC
        



Review of attachment 232234 [details] [review]:

::: src/empathy-roster-window.c
@@ +482,3 @@
+    gtk_widget_set_sensitive (self->priv->button_add_contact,
+        can_add_contact (self));
+

Now you have 2 places where you call gtk_widget_set_visible() on button_add_contact. I think it would be nicer to change the gtk_widget_set_visible() above with "(flags & PAGE_MESSAGE_FLAG_ADD_CONTACT) != 0 && can_add_contact (self)".






Comment 3


Guillaume Desmottes





          2012-12-26 11:47:00 UTC
        



Review of attachment 232234 [details] [review]:

::: src/empathy-roster-window.c
@@ +482,3 @@
+    gtk_widget_set_sensitive (self->priv->button_add_contact,
+        can_add_contact (self));
+

No, in this case the button is displayed (set_visibile (true)) but not sensitive (set_sensitive (false)). Do you think I should hide it in this case as well?






Comment 4


Xavier Claessens





          2012-12-26 11:47:47 UTC
        



+1






Comment 5


Guillaume Desmottes





          2012-12-26 11:48:51 UTC
        



Attachment 232234 [details] pushed as b3ab97d - roster-window: prevent adding contact if not supported by CM