GNOME Bugzilla – Bug 690722
GTK+ filechooser path entry "edit" icon is fuzzy
Last modified: 2014-04-28 20:26:46 UTC
Created attachment 232224 [details] 200% screenshot As the attached screenshot shows, the "edit" icon used in the togglebutton on the upper-left corner of the open filechooser is not sharp/pixel-perfect. This can be caused either by the wrong icon size being set on that togglebutton widget or by the icon file itself having been designed with the wrong canvas size. I tried looking for that icon file but couldn't find it, so if you can tell me where it is I could provide a modified version if the icon is the culprit.
Another possibility is that the icon is of the correct size, but that it is vectorial without being aligned to the pixel grid. If that's the case, point me to it and I will offer a fixed version.
*** Bug 691644 has been marked as a duplicate of this bug. ***
Hi, although I couldn't reproduce it, I found that the 16x16 gtk-edit.png is much more blurry than other stock items of the same size. The icon can be found under /gtk/stock-icons/16/ in the source. 24x24 version looks fine, though
Are you still able to reproduce this in a latest version of GTK? The icons dont seem to have changed since 2007 so I doubt they are the cause if others cant reproduce. Also just to get a little more information what application was used to open the filechooser? Was it a GTK 2 or GTK 3 application?
Timothy: still reproducible in GTK 3.8 with Gedit's "open file" chooser.
Additional clues: the icon used by the file chooser is clearly the 24x24px version (as you can see the line near the lower tip of the pencil)... however, why is it that the folder icon (a little bit to its right) is the 16x16 version (measured with GIMP)? Is GTK trying to shoehorn the 24x24 version of gtk-edit into a 16x16 space? https://git.gnome.org/browse/gtk+/plain/gtk/stock-icons/24/gtk-edit.png https://git.gnome.org/browse/gtk+/plain/gtk/stock-icons/16/gtk-edit.png
...and I should note that upon inspection of the 24x24 and 16x16 gtk-edit icons in Inkscape, they are perfectly aligned to the pixel grid (except the edges of the "text" lines in the 16x16 icon, but maybe that's intentional), so it's definitely not the icon's fault but probably gtk doing something odd.
Created attachment 247194 [details] glade file to compare "gtk-edit" to various other icons Comparing with other icons in various situations, it might turn out to be a problem with the icon after all...
Created attachment 247195 [details] screenshot comparing "gtk-edit" with other icons, in various sizes This demonstrates that something is wrong with the gtk-edit icon in particular, as other icon names are unaffected. Red guidelines were added with GIMP, revealing that the gtk-edit icon uses the 24x24 grid too aggressively and does not natively fit in a 22x22 space, unlike other icons that were compared.
Created attachment 247197 [details] [review] proposed patch This patch makes the 24x24 icon files pixel-perfect while having an empty 1px "border" so it can be cropped to 22x22 (I suspect this is what GTK is doing) for the automatic size required by the buttons by default. Beware of bugs in the above patch; I have only proved it correct, not tried it. At the same time, regardless of the successfulness of this patch to fixing the bug at hand, it is a graphical improvement to the icon that should be able to stand on its own.
I'm not sure who maintains the icons you might like to ask on the gtk mailing list for a review/commit of your patch otherwise it could be missed.
We don't show an edit icon anymore