GNOME Bugzilla – Bug 690720
Wrong texts in contact details
Last modified: 2013-01-19 11:08:32 UTC
Two texts contain visible HTML markup symbols: - <b>Instant messaging</b> on the contact tab. - <b>Webadressen</b> on the personal information tab. Found in 3.4 but also wrong in newer versions.
Created attachment 232219 [details] Fix for 3.4
Created attachment 232220 [details] Fix for 3.6
Created attachment 232221 [details] Fix for 3.8
Comment on attachment 232219 [details] Fix for 3.4 This is not a patch - please only attach a patch/diff instead of the whole file.
Comment on attachment 232220 [details] Fix for 3.6 This is not a patch - please only attach a patch/diff instead of the whole file.
Comment on attachment 232221 [details] Fix for 3.8 This is not a patch - please only attach a patch/diff instead of the whole file.
Okay, could you please point me to the right procedure to create a good patch? Thanks in advance.
(In reply to comment #7) > Okay, could you please point me to the right procedure to create a good patch? > Thanks in advance. https://live.gnome.org/Git/WorkingWithPatches#How_to_make_a_patch should get you started! :-)
Created attachment 232787 [details] [review] Fix Dutch translation for contacts window Two Dutch texts contain visible HTML markup symbols: - <b>Instant messaging</b> on the contact tab. - <b>Webadressen</b> on the personal information tab.
I tried to create the patch (although I am very new at this). Please also review it as I don't know how to test my local changes in a running version of the app.
Stupid question, but what module does this patch apply to? I can't find the relevant strings in the modules gnome-contacts or contacts.
I am not an Evolution programmer but by browsing the source tree I think the string are used in evolution/tree/addressbook/gui/contact-editor/contact-editor.ui
Right, so this is just a wrong translation in Evolution. I wish I'd have known earlier! I'm sorry we made you jump through this patch-making hoops. Next time, could you please instead create an account on Damned Lies (http://l10n.gnome.org/) and upload your fixed nl.po to the relevant module in the Dutch subsection? Thanks a lot! Follow progress on http://l10n.gnome.org/vertimus/evolution/master/po/nl
commit f6423ccdc57774c7a0869d8d6818dacb2c9c3031 (HEAD, origin/master, origin/HEAD, master) Author: Patrick Holthuizen <patrick@eaze.org> Date: 2 minutes ago Updated Dutch translation by Patrick Holthuizen (bug 690720)