After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690616 - 'GSD_WACOM_ACTION_TYPE_HELP' undeclared
'GSD_WACOM_ACTION_TYPE_HELP' undeclared
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Wacom
git master
Other Linux
: Normal major
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-21 15:52 UTC by Jeremy Bicha
Modified: 2013-01-02 10:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
buildlog (514.32 KB, application/octet-stream)
2012-12-21 15:52 UTC, Jeremy Bicha
Details

Description Jeremy Bicha 2012-12-21 15:52:48 UTC
Created attachment 232066 [details]
buildlog

gnome-control-center 3.7.3 won't build with LDFLAGS += -Wl,-z,defs:

make[5]: Entering directory `/«PKGBUILDDIR»/panels/wacom'
/bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../ -DG_LOG_DOMAIN="\"wacom-cc-panel\"" -DPANEL_ID="\"wacom\"$
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../ -DG_LOG_DOMAIN=\"wacom-cc-panel\" -DPANEL_ID=\"wacom\" -pthread -I/usr/include/gtk-3.0 -I$
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../ -DG_LOG_DOMAIN=\"wacom-cc-panel\" -DPANEL_ID=\"wacom\" -pthread -I/usr/include/gtk-3.0 -I$
/bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -I../../ -DG_LOG_DOMAIN="\"wacom-cc-panel\"" -DPANEL_ID="\"wacom\"$
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -I../../ -DG_LOG_DOMAIN=\"wacom-cc-panel\" -DPANEL_ID=\"wacom\" -pthread -I/usr/include/gtk-3.0 -I$
cc-wacom-page.c:121:10: error: 'GSD_WACOM_ACTION_TYPE_HELP' undeclared here (not in a function)
cc-wacom-page.c: In function 'setup_mapping_treeview':
cc-wacom-page.c:770:35: warning: comparison between pointer and integer [enabled by default]
make[5]: *** [cc-wacom-page.lo] Error 1
Comment 1 Jeremy Bicha 2012-12-21 19:38:31 UTC
And shouldn't we have the default jhbuild build fail if there are undefined symbols so that we can catch these problems sooner?
Comment 2 Matthias Clasen 2012-12-23 17:59:35 UTC
Addressed by 

commit 3f8a3cf52943900220cd9715d6df69769f1794ec
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu Dec 20 09:52:02 2012 +0100

    3.8: Update libwacom dependency to 0.7
Comment 3 Bastien Nocera 2012-12-23 18:17:05 UTC
That's not the fix. We need to bump the gsd dep. Then again you need to install gsd and gcc from the same releases.
Comment 4 Jeremy Bicha 2012-12-25 03:42:06 UTC
Bastien, thanks. I intended to build with g-s-d 3.7.3 but it looks like I didn't (as it builds fine now). So the fix for this bug is to simply bump the dependency.
Comment 5 Bastien Nocera 2013-01-02 10:50:24 UTC
Bumped in master