After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690590 - messagetray mouse focus issue for legacy icons
messagetray mouse focus issue for legacy icons
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 681540
 
 
Reported: 2012-12-21 02:14 UTC by darkxst
Modified: 2013-01-02 18:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
display: Expose the xinput opcode (1.43 KB, patch)
2012-12-21 02:52 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
gnome-shell-plugin: Extract focus notification ignores (3.56 KB, patch)
2012-12-21 02:52 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
gnome-shell-plugin: Port event filter to XInput2 (3.23 KB, patch)
2012-12-21 02:52 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description darkxst 2012-12-21 02:14:30 UTC
I have noticed that sometimes its really hard to get mouse focus on some icons in the messagetray. Most if not all of the affected icons seem to be legacy icons.

For affected icons you need to actually mouse over the outline/edge of focus highlight box to get the focus.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-12-21 02:52:24 UTC
Created attachment 232026 [details] [review]
display: Expose the xinput opcode

This is needed by the shell to filter out certain events
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-12-21 02:52:53 UTC
Created attachment 232027 [details] [review]
gnome-shell-plugin: Extract focus notification ignores

This is a preliminary patch to make the diff in the next patch
cleaner. This just shuffles code around without changing anything.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-12-21 02:52:56 UTC
Created attachment 232028 [details] [review]
gnome-shell-plugin: Port event filter to XInput2

Otherwise, we'll see issues with tray icons.
Comment 4 darkxst 2012-12-21 03:09:25 UTC
I can confirm the issue is resolved with the above patches
Comment 5 drago01 2013-01-02 18:34:47 UTC
Review of attachment 232026 [details] [review]:

OK.
Comment 6 drago01 2013-01-02 18:35:53 UTC
Review of attachment 232027 [details] [review]:

OK.
Comment 7 drago01 2013-01-02 18:37:02 UTC
Review of attachment 232028 [details] [review]:

Can't test this either, but looks good to me.
Comment 8 Jasper St. Pierre (not reading bugmail) 2013-01-02 18:42:48 UTC
Comment on attachment 232026 [details] [review]
display: Expose the xinput opcode

Attachment 232026 [details] pushed as 90cf43d - display: Expose the xinput opcode
Comment 9 Jasper St. Pierre (not reading bugmail) 2013-01-02 18:43:56 UTC
Attachment 232028 [details] pushed as 9f9518c - gnome-shell-plugin: Port event filter to XInput2