After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690589 - Show the headphones icon in the lock screen
Show the headphones icon in the lock screen
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-21 01:58 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-12-21 18:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
panelMenu: Remove inaccurate comment (913 bytes, patch)
2012-12-21 01:58 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
lockScreenMenu: Construct actual panel icons much more accurately (5.50 KB, patch)
2012-12-21 01:58 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
lockScreenMenu: Construct actual panel icons much more accurately (5.62 KB, patch)
2012-12-21 17:29 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-12-21 01:58:18 UTC 
I asked on #gnome-design about this, after the volume menu cleanups.
This is a general cleanup for lock screen item construction, too, and
should allow the volume patches to succeed there.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-12-21 01:58:21 UTC 
Created attachment 232021 [details] [review]
panelMenu: Remove inaccurate comment

This has been out of date ever since the -symbolic fallbacks
have gone away.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-12-21 01:58:24 UTC 
Created attachment 232022 [details] [review]
lockScreenMenu: Construct actual panel icons much more accurately

Instead of faking it by adding a bunch of main icons and secondary
icons to our own box, try and recreate the original button box
with the original icons.
Comment 3 Giovanni Campagna 2012-12-21 17:23:00 UTC 
Review of attachment 232021 [details] [review]:

Yes
Comment 4 Giovanni Campagna 2012-12-21 17:25:29 UTC 
Review of attachment 232022 [details] [review]:

Almost.

::: js/ui/status/lockScreenMenu.js
@@ +49,3 @@
+
+        this._volume = new FakeStatusIcon(Main.panel.statusArea.volume);
+        this._network = new FakeStatusIcon(Main.panel.statusArea.network);

You lost the if condition: _network may not exist if NM libraries are missing.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-12-21 17:29:40 UTC 
Created attachment 232076 [details] [review]
lockScreenMenu: Construct actual panel icons much more accurately

Instead of faking it by adding a bunch of main icons and secondary
icons to our own box, try and recreate the original button box
with the original icons.
Comment 6 Giovanni Campagna 2012-12-21 17:59:22 UTC 
Review of attachment 232076 [details] [review]:

Yes.
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-12-21 18:26:05 UTC 
Attachment 232021 [details] pushed as 994021d - panelMenu: Remove inaccurate comment
Attachment 232076 [details] pushed as 1d136ca - lockScreenMenu: Construct actual panel icons much more accurately