After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690582 - Import bluez plugins into -bad and port to 1.0
Import bluez plugins into -bad and port to 1.0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-20 23:36 UTC by Tim-Philipp Müller
Modified: 2013-04-02 20:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtp: Add an rtpsbcdepay element (12.43 KB, patch)
2013-03-28 16:51 UTC, Arun Raghavan
committed Details | Review

Description Tim-Philipp Müller 2012-12-20 23:36:36 UTC
Subject says it all.
Comment 1 Tim-Philipp Müller 2013-01-09 18:24:41 UTC
commit 70ba34c485c379180298ab9c35dc09da24ebe0b5
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Wed Jan 9 18:10:30 2013 +0000

    bluez: add new plugin to build system, but disable for now
    
    Disable until it has been tested and works.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690582

commit c994ae021de29e28ec6ffd3c51cb6c7ea18de401
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Wed Jan 9 18:02:11 2013 +0000

    bluez: make bluez elements compile with 1.0
    
    Builds, but very likely doesn't work yet at all. Some
    things are still commented out.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690582


Next: sbc stuff into ext/sbc/ and rtp payload stuff into -good/gst/rtp/
Comment 2 Tim-Philipp Müller 2013-01-10 12:45:01 UTC
commit 39ef892938ba56765c1fa62398ef8e49e7374c7e
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Thu Jan 10 12:38:13 2013 +0000

    rtp: import rtpsbcpay from bluez and port to 1.0
    
    Compiles, but not tested yet (sbc elements still need to be ported).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690582
Comment 3 Tim-Philipp Müller 2013-01-15 18:04:58 UTC
commit fcd8566665d6cf6ffbe186480ed229e2dc82baa4
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Tue Jan 15 17:27:31 2013 +0000

    typefinding: add typefind functions for SBC audio
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690582

commit 9f7a9497731556ab9249354d697e949a9b3e24d9
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Tue Jan 15 17:38:24 2013 +0000

    audioparsers: add SBC audio parser
    
    From-scratch rewrite, the bluez one was useless and broken.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690582
Comment 4 Tim-Philipp Müller 2013-03-27 22:46:56 UTC
commit a028a05054a66a1b8cf2c6700c3784cd7502f8e5
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Wed Mar 27 13:11:11 2013 +0000

    sbc: port encoder to GstAudioEncoder
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690582

commit ca9daee444b0711a27e1a1c0ca9aa8d93dc37588
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Tue Mar 26 13:55:32 2013 +0000

    sbc: port decoder to GstAudioDecoder
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690582

commit fecddde2c2de612bbeca5d3ee7d573fd929b949e
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Wed Jan 16 11:36:25 2013 +0000

    sbc: import sbc decoder/encoder from bluez and port to 1.0
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690582

commit 89bbcdea397671cafbf67b81244846ec372e72f1
Merge: a1bb437 50643d6
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Wed Mar 27 22:24:03 2013 +0000

    Merge SBC decoder and encoder from bluez
    
    https://bugzilla.gnome.org/show_bug.cgi?id=690582



Now we just need to test the bluez elements, so they can be enabled. (And maybe port them to bluez5 or add support for bluez5?)
Comment 5 Arun Raghavan 2013-03-28 16:51:16 UTC
Created attachment 240071 [details] [review]
rtp: Add an rtpsbcdepay element
Comment 6 Arun Raghavan 2013-03-28 16:55:17 UTC
(In reply to comment #5)
> Created an attachment (id=240071) [details] [review]
> rtp: Add an rtpsbcdepay element

This, along with my tree below adds support for streaming _from_ a Bluetooth device.

http://cgit.collabora.com/git/user/arun/gst-plugins-bad.git/

This work was originally done on BlueZ 4.101 for 0.10, but didn't make it upstream since 5.x was under way at the time. Now ported and functional on git master.
Comment 7 Arun Raghavan 2013-03-28 17:33:47 UTC
Comment on attachment 240071 [details] [review]
rtp: Add an rtpsbcdepay element

Committed with a commit message fix and addition of authorship line in header.
Comment 8 Arun Raghavan 2013-03-28 17:40:52 UTC
Pushed the source element as well based on Sebastian's review (thanks!). The a2dpsrc element was removed since there wasn't a clear use for it.
Comment 9 Tim-Philipp Müller 2013-03-29 00:08:26 UTC
Guess we can enable the bluez plugin now and close this?
Comment 10 Tim-Philipp Müller 2013-04-02 20:53:53 UTC
Enabled now.