After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690554 - Generated vtetypebuiltins.h may contain build directory name
Generated vtetypebuiltins.h may contain build directory name
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.34.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
[fixed-next]
Depends on:
Blocks:
 
 
Reported: 2012-12-20 12:20 UTC by Colin Watson
Modified: 2014-04-06 18:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use @basename@ rather than @filename@ in vtetypebuiltins.h (1.69 KB, patch)
2012-12-20 12:20 UTC, Colin Watson 		committed Details | Review

Description Colin Watson 2012-12-20 12:20:28 UTC 
Created attachment 231976 [details] [review]
Use @basename@ rather than @filename@ in vtetypebuiltins.h

On Debian/Ubuntu-based systems it is helpful for headers to be identical across architectures, thereby allowing the -dev packages from multiple architectures to be installed simultaneously; in particular, this simplifies cross-building.  When building out-of-tree, the use of @filename@ causes the build directory to end up in the generated header file, which means that it isn't reliably identical on all architectures.  Using @basename@ instead fixes this problem.
Comment 1 Christian Persch 2012-12-20 12:29:08 UTC 
I'd rather fix this properly, by not distributing generated files at all. So move the vtetypebuiltins.[ch] and marshal.[ch] files to nodist_..._SOURCES .
Comment 2 Colin Watson 2012-12-20 12:53:13 UTC 
Distribution is irrelevant; I'm talking about installation.  vtetypebuiltins.h is included by vte.h, so it's part of the public API and I don't think you can just stop installing it.
Comment 3 Christian Persch 2012-12-20 12:57:49 UTC 
Hmm you're right. Ok to commit then (vte-0-34 branch). Leave the bug open for vte-next and the nodist_... thing.
Comment 4 Colin Watson 2012-12-20 13:05:54 UTC 
OK, committed to vte-0-34, thanks.  Do you merge to vte-next en masse?