GNOME Bugzilla – Bug 690500
default-monitors-setup used only at boot time, not for autoconfigure
Last modified: 2013-01-28 19:46:58 UTC
Created attachment 231891 [details] [review] patch to use default-monitors-setup consistently The behavior for hot- and cold-plug of an external monitor is inconsistent. Despite the name, the "default-monitors-setup" key is only used at boot time. After hot-plug of an external monitor, the "xinerama" setup is always used.
Review of attachment 231891 [details] [review]: Makes sense to me
Review of attachment 231891 [details] [review]: Looks good.
I've pushed this. One small issue though: We still only autoconfigure if there is no stored configuration. That means if you change the default-monitors-setup, you won't get a new configuration the next time you plug in, but instead the stored configuration. That may need some changes if we decide to expose the default-monitors-setup key as user configuration.
There seems to be a small issue with that patch: + case GSD_XRANDR_BOOT_BEHAVIOUR_DO_NOTHING: + config = make_xinerama_setup (manager, priv->rw_screen); + break; That assumes that "xinerama" is the default behaviour for xorg, which doesn't seem to be the case upstream? Fedora carries a distro patch that seems to change their default though: http://pkgs.fedoraproject.org/cgit/xorg-x11-server.git/tree/xserver-1.6.99-right-of.patch Should the upstream code call "make_mirror_setup()" then?