After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690500 - default-monitors-setup used only at boot time, not for autoconfigure
default-monitors-setup used only at boot time, not for autoconfigure
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: xrandr
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-19 14:55 UTC by Paolo Bonzini
Modified: 2013-01-28 19:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to use default-monitors-setup consistently (4.00 KB, patch)
2012-12-19 14:55 UTC, Paolo Bonzini
accepted-commit_now Details | Review

Description Paolo Bonzini 2012-12-19 14:55:56 UTC
Created attachment 231891 [details] [review]
patch to use default-monitors-setup consistently

The behavior for hot- and cold-plug of an external monitor is inconsistent.  Despite the name, the "default-monitors-setup" key is only used at
boot time.  After hot-plug of an external monitor, the "xinerama" setup
is always used.
Comment 1 Matthias Clasen 2012-12-28 22:14:08 UTC
Review of attachment 231891 [details] [review]:

Makes sense to me
Comment 2 Bastien Nocera 2013-01-02 15:36:58 UTC
Review of attachment 231891 [details] [review]:

Looks good.
Comment 3 Matthias Clasen 2013-01-02 19:26:19 UTC
I've pushed this. One small issue though: We still only autoconfigure if there is no stored configuration. That means if you change the default-monitors-setup, you won't get a new configuration the next time you plug in, but instead the stored configuration. That may need some changes if we decide to expose the default-monitors-setup key as user configuration.
Comment 4 Sebastien Bacher 2013-01-28 19:46:58 UTC
There seems to be a small issue with that patch:

+ case GSD_XRANDR_BOOT_BEHAVIOUR_DO_NOTHING:
+ config = make_xinerama_setup (manager, priv->rw_screen);
+ break;

That assumes that "xinerama" is the default behaviour for xorg, which doesn't seem to be the case upstream?

Fedora carries a distro patch that seems to change their default though:
http://pkgs.fedoraproject.org/cgit/xorg-x11-server.git/tree/xserver-1.6.99-right-of.patch

Should the upstream code call "make_mirror_setup()" then?