After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690480 - [BUG] Flip Tool inverts image incorrectly.
[BUG] Flip Tool inverts image incorrectly.
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: GeglBuffer
git master
Other All
: Normal major
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2012-12-19 08:29 UTC by paul_geraskin
Modified: 2013-06-09 20:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
image for testing (139.58 KB, image/png)
2012-12-19 08:29 UTC, paul_geraskin 		Details

Description paul_geraskin 2012-12-19 08:29:57 UTC 
Created attachment 231864 [details]
image for testing

Hi Devs!

In some cases the Flip Tool (Shift+F) flips an image incorrectly.
Tested on Gimp 2.9 git master.


my test - http://i.imgur.com/rXQbf.png
Image source - http://dl.dropbox.com/u/26887202/blender/ee.png
Comment 1 Øyvind Kolås (pippin) 2012-12-19 09:19:56 UTC 
08:43 < mitch_> better fix gegl_buffer_copy() on odd-sized buffers ;)
08:43 < mitch_> totally b0rk
08:43 < mitch_> see the gimp-devel mail about flip
08:44 < mitch_> -> work
08:52 < pippin> flip uses copy? and it only happens on odd-wide buffers?
09:15 < mitch_> pippin: exactly
09:15 < mitch_> gegl_buffer_copy, in rows/columns
09:16 < mitch_> gimp_drawable_transform_buffer_flip()
09:16 < mitch_> i added printf on the copied rectangles in that function, they are correct
Comment 2 Mike Henning (drawoc) 2013-06-09 20:59:57 UTC 
This is fixed now. I'm not sure, but I suspect this commit fixed it:

commit aac9e9719d5a6be8fe22352448098d8380805a23
Author: Daniel Sabo
Date:   Tue Apr 9 14:15:26 2013 -0700

    Fix overshoot in gegl_buffer_copy
    
    Don't attempt to COW copy a rect smaller than a tile,
    doing so will cause cow.y to get pushed outside of
    the original rect and copy more than it's supposed to.