After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690459 - Glib::Object::Subclass no hash arguments to register_object
Glib::Object::Subclass no hash arguments to register_object
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Glib
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2012-12-18 22:44 UTC by Kevin Ryde
Modified: 2013-01-03 23:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.17 KB, patch)
2012-12-18 22:44 UTC, Kevin Ryde 		committed Details | Review

Description Kevin Ryde 2012-12-18 22:44:51 UTC 
Created attachment 231843 [details] [review]
patch

As from the mailing list this is an idea to pass Glib::Object::Subclass import arguments directly to register_object() without putting them through a hash table.

Would like register_object() not to depend on the order of its key/value args, but putting them straight through helps avoid perl 5.17 randomization now, and either way is a small speedup.
Comment 1 Torsten Schoenfeld 2013-01-03 23:23:03 UTC 
Patch committed (after some reformatting of the commit message), thanks.

In a previous commit, I think I fixed the underlying problem of
Glib::Type->register_object's order dependence.