GNOME Bugzilla – Bug 690447
Set printer dialog titles
Last modified: 2013-02-18 13:01:08 UTC
Currently, the titles for the printer dialogs are included in the window body. This is incorrect - the title should be in the window titlebar, and should be set as a window property. Dialogs affected by this bug include: * add printer * printer jobs * printer options There may be other printer dialogs that are also affected.
The dialogs don't have a titlebars because they are dialogs which are transient to their parents. Do you want to make them regular windows? I prefer the current titles.
(In reply to comment #1) > The dialogs don't have a titlebars because they are dialogs which are transient > to their parents. Do you want to make them regular windows? > I prefer the current titles. I was wrong here. I don't see the titles because I use "Mist" theme which doesn't show titles for dialogs (maybe a bug...). I'll look at this at Monday.
Created attachment 235697 [details] [review] move dialog names to their title Attached patch moves the dialog names to their titles. It does so for jobs dialog, new printer dialog, options dialog and ppd selection dialog.ui.
Created attachment 235698 [details] screenshots of the change
Looks much better!
Review of attachment 235697 [details] [review]: ::: panels/printers/new-printer-dialog.ui @@ +134,3 @@ + <property name="secondary_icon_tooltip_text" translatable="yes">Search for network printers or filter result</property> + <property name="secondary_icon_tooltip_markup" translatable="yes">Search for network printers or filter result</property> + <property name="placeholder_text">Enter address of a printer or a text to filter results</property> "The text that will be displayed in the GtkEntry when it is empty and unfocused." This is a far too long placeholder-text. ::: panels/printers/pp-jobs-dialog.c @@ +496,1 @@ title = g_strdup_printf (_("%s Active Jobs"), printer_name); As a separate bug, this is wrong for a lot of languages. See about using g_dngettext()
(In reply to comment #6) > Review of attachment 235697 [details] [review]: > > ::: panels/printers/new-printer-dialog.ui > @@ +134,3 @@ > + <property name="secondary_icon_tooltip_text" > translatable="yes">Search for network printers or filter result</property> > + <property name="secondary_icon_tooltip_markup" > translatable="yes">Search for network printers or filter result</property> > + <property name="placeholder_text">Enter > address of a printer or a text to filter results</property> > > "The text that will be displayed in the GtkEntry when it is empty and > unfocused." > > This is a far too long placeholder-text. This part of the patch just moves those tags, it doesn't add them. We are discussing the text in https://bugzilla.gnome.org/show_bug.cgi?id=690366. > ::: panels/printers/pp-jobs-dialog.c > @@ +496,1 @@ > title = g_strdup_printf (_("%s Active Jobs"), printer_name); > > As a separate bug, this is wrong for a lot of languages. See about using > g_dngettext() I'll look at this.
(In reply to comment #7) > (In reply to comment #6) > > Review of attachment 235697 [details] [review] [details]: > > > > ::: panels/printers/new-printer-dialog.ui > > @@ +134,3 @@ > > + <property name="secondary_icon_tooltip_text" > > translatable="yes">Search for network printers or filter result</property> > > + <property name="secondary_icon_tooltip_markup" > > translatable="yes">Search for network printers or filter result</property> > > + <property name="placeholder_text">Enter > > address of a printer or a text to filter results</property> > > > > "The text that will be displayed in the GtkEntry when it is empty and > > unfocused." > > > > This is a far too long placeholder-text. > > This part of the patch just moves those tags, it doesn't add them. We are > discussing the text in https://bugzilla.gnome.org/show_bug.cgi?id=690366. OK. > > ::: panels/printers/pp-jobs-dialog.c > > @@ +496,1 @@ > > title = g_strdup_printf (_("%s Active Jobs"), printer_name); > > > > As a separate bug, this is wrong for a lot of languages. See about using > > g_dngettext() > > I'll look at this. File a separate bug about it please.
Comment on attachment 235697 [details] [review] move dialog names to their title I've committed the patch.
> > > ::: panels/printers/pp-jobs-dialog.c > > > @@ +496,1 @@ > > > title = g_strdup_printf (_("%s Active Jobs"), printer_name); > > > > > > As a separate bug, this is wrong for a lot of languages. See about using > > > g_dngettext() > > > > I'll look at this. > > File a separate bug about it please. Ok, I will. I'm closing this. Thank you for your help. Marek
(In reply to comment #8) > > > ::: panels/printers/pp-jobs-dialog.c > > > @@ +496,1 @@ > > > title = g_strdup_printf (_("%s Active Jobs"), printer_name); > > > > > > As a separate bug, this is wrong for a lot of languages. See about using > > > g_dngettext() > > > > I'll look at this. > > File a separate bug about it please. Looking at this, it seems correct to me. The "%s Active Jobs" expands to e.g. "NameOfMyPrinter Active Jobs". It is a title of dialog which shows list of active jobs. So it I think that using plural form is correct here. (sorry for spamming in closed bug)
(In reply to comment #11) > (In reply to comment #8) > > > > ::: panels/printers/pp-jobs-dialog.c > > > > @@ +496,1 @@ > > > > title = g_strdup_printf (_("%s Active Jobs"), printer_name); > > > > > > > > As a separate bug, this is wrong for a lot of languages. See about using > > > > g_dngettext() > > > > > > I'll look at this. > > > > File a separate bug about it please. > > Looking at this, it seems correct to me. The "%s Active Jobs" expands to e.g. > "NameOfMyPrinter Active Jobs". It is a title of dialog which shows list of > active jobs. So it I think that using plural form is correct here. OK, I thought it might be used in a label instead. > (sorry for spamming in closed bug) It's the right place to do this in this case :)