After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690445 - (applet) Integrate the new ModemManager1 interface
(applet) Integrate the new ModemManager1 interface
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
0.9.x
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-12-18 19:00 UTC by Aleksander Morgado
Modified: 2013-01-15 10:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Aleksander Morgado 2012-12-18 19:00:07 UTC 
ModemManager >= 0.7.x will come with a new 'ModemManager1' DBus interface.

nm-applet should handle modem objects exported by MM in the new interface.
Comment 1 Aleksander Morgado 2012-12-18 19:03:59 UTC 
The 'aleksander/mm1-applet' in upstream git contains the new ModemManager1 interface support. Actually, only the last patch is the one introducing the new interface support, the previous ones are either some other fixes or code re-structuring needed to easily integrate the MM1 support afterwards. I tried to keep them as independent as possible so that they can be reviewed separately.
Comment 2 Dan Williams 2013-01-14 20:34:27 UTC 
Overall looks great.  However, there are some whitespace problems in "new support for the ModemManager1 interface" like in broadband_state_to_mb_state() and a few other places.

Warnings:

- applet_mobile_pin_dialog_new() has an unused variable (device_desc)
- mobile_helper_parse_3gpp_operator_name() uses isdigit(), but <ctype.h> isn't included
Comment 3 Dan Williams 2013-01-14 20:34:44 UTC 
Fix those and feel free to merge, thanks!
Comment 4 Aleksander Morgado 2013-01-15 10:31:58 UTC 
Already had patches for those warnings from mariusko, not sure why I didn't push the branch with them..

Fixed the whitespace fixes, and merged the branch now.

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.