After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690444 - Default printer icon issues
Default printer icon issues
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Printers
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: Marek Kašík
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-18 18:56 UTC by Allan Day
Modified: 2013-01-16 11:45 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6


Attachments
screenshot (107.59 KB, image/png)
2012-12-18 18:56 UTC, Allan Day
  Details
have nicer icon for default printer (1.42 KB, patch)
2013-01-16 10:58 UTC, Marek Kašík
committed Details | Review
screenshot of the new icon and its state (32.73 KB, image/png)
2013-01-16 10:58 UTC, Marek Kašík
  Details

Description Allan Day 2012-12-18 18:56:40 UTC
Created attachment 231827 [details]
screenshot

The default printer is indicated by an icon in the printer list. There are two issues with the icon:

 * the icon should be white when the printer is selected (like the text
 * object-select-symbolic should be used, and not emblem-default-symbolic
Comment 1 Marek Kašík 2013-01-16 10:58:09 UTC
Created attachment 233580 [details] [review]
have nicer icon for default printer

This patch changes the icon of default pritner from emblem-default-symbolic
to object-select-symbolic and make the icon to follow the state of the cell
in which the icon is placed.
Comment 2 Marek Kašík 2013-01-16 10:58:37 UTC
Created attachment 233581 [details]
screenshot of the new icon and its state
Comment 3 Allan Day 2013-01-16 11:07:57 UTC
Perfect!
Comment 4 Bastien Nocera 2013-01-16 11:15:23 UTC
Review of attachment 233580 [details] [review]:

++
Comment 5 Marek Kašík 2013-01-16 11:44:26 UTC
Comment on attachment 233580 [details] [review]
have nicer icon for default printer

Thanks for the review and the report. I've committed the patch to master.