After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690387 - keyboard: Improve shortcuts tab keynav
keyboard: Improve shortcuts tab keynav
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
3.7.x
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-17 23:33 UTC by Stéphane Démurget
Modified: 2012-12-18 11:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
keyboard: Improve shortcuts tab keynav (2.62 KB, patch)
2012-12-17 23:33 UTC, Stéphane Démurget 		committed Details | Review

Description Stéphane Démurget 2012-12-17 23:33:52 UTC 
The shortcuts tab have its treeviews in an unnatural order.
Fix that by setting a focus_chain on the parent container.
Comment 1 Stéphane Démurget 2012-12-17 23:33:55 UTC 
Created attachment 231781 [details] [review]
keyboard: Improve shortcuts tab keynav

The default focus traversal order inside the shortcuts tab was: the
shortcuts treeview, the section treeview and the shortcuts toolbar.

We set a focus cycle chain to swap the treeviews order for the keynav to
be more natural.
Comment 2 Bastien Nocera 2012-12-18 09:53:37 UTC 
Review of attachment 231781 [details] [review]:

Rest looks good.

::: panels/keyboard/keyboard-shortcuts.c
@@ +1798,3 @@
+  /* set up the focus chain */
+  focus_chain = NULL;
+  focus_chain = g_list_append (focus_chain, WID (builder, "sections_swindow"));

do "g_list_append (NULL..." directly, no need to initialise the list.
Comment 3 Stéphane Démurget 2012-12-18 11:23:45 UTC 
Attachment 231781 [details] pushed as 0e7192e - keyboard: Improve shortcuts tab keynav
Comment 4 Stéphane Démurget 2012-12-18 11:26:59 UTC 
Also pushed to stable gnome-3-4 and gnome-3-6 branches.