After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690379 - Atk lacks any kind of version utilities
Atk lacks any kind of version utilities
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: atk
unspecified
Other Linux
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-12-17 19:51 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2012-12-28 16:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixes the bug (10.92 KB, patch)
2012-12-27 19:38 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
committed Details | Review
Little test (736 bytes, patch)
2012-12-27 19:40 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
none Details | Review

Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-12-17 19:51:58 UTC
Several glib based projects include some basic API in order to request the current version of the installed library. But ATK lacks those. Those utilities are useful for some other libraries using them, like for example WebKitGTK that uses it in order to know which functionality can use. 

We can take gtk [1] and clutter [2] ones as example.



[1] http://git.gnome.org/browse/gtk+/tree/gtk/gtkversion.h.in
[2] http://git.gnome.org/browse/clutter/tree/clutter/clutter-version.h.in
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-12-27 19:38:08 UTC
Created attachment 232292 [details] [review]
Fixes the bug

It adds several macro and function utilities related to atk versioning. This is heavily based on gtk ones (also the documentation). I took a look to clutter ones and I think that for the moment we don't need so many utilities.

This patch also includes the changes on /doc, in order to include the documentation of this utilities.
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-12-27 19:40:39 UTC
Created attachment 232293 [details] [review]
Little test

This is a little test that use the new API added on the patch I have just attached. Not sure if it is worth to include a more formal form of this test on any future set of ATK unit tests (feedback is welcome) (note: there is a tests directory on ATK. They are obsolete, and somehow not really useful, as they are implemented as GTK modules)
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-12-28 16:04:57 UTC
(In reply to comment #1)
> Created an attachment (id=232292) [details] [review]
> Fixes the bug
> 

Patch committed with some documentation typos fixed. Closing the bug.