GNOME Bugzilla – Bug 690353
Notification icons appear all-black
Last modified: 2013-02-11 22:04:45 UTC
Created attachment 231724 [details] [review] patch Running gnome-panel-3.6.2 and gtk3-3.6.2 on Fedora 18, some notification icons (battery, bluetooth) appear all-black, on an all black background, i.e. you can't see them. Reproduced on different models of the OLPC XO and also on my regular dell laptop. Stepping into the code shows that the style specified by the notification area protocol is not being applied. The attached patch fixes it.
Review of attachment 231724 [details] [review]: Interesting. I'm wondering why it was working before. Maybe the style was updated after a realize before? Do you have any idea? ::: applets/notification_area/main.c @@ +82,3 @@ gtk_container_add (GTK_CONTAINER (widget), GTK_WIDGET (applet->priv->tray)); gtk_widget_show (GTK_WIDGET (applet->priv->tray)); + na_tray_applet_style_updated (widget); Maybe move this before the gtk_widget_show(), to avoid changing the style after showing things?
Created attachment 233705 [details] [review] updated patch I inserted some printf messages in the applet to investigate the behaviour change. On F17 where this worked, the sequence of events was: 1. na_tray_applet_style_updated() called 2. Enter na_tray_applet_realize() 3. na_tray_applet_style_updated() called again 4. na_tray_applet_realize() calls gtk_widget_show 5. na_tray_applet_realize() returns 6. na_tray_applet_style_updated() is invoked 4 more times On F18 where it is broken, it is: 1. na_tray_applet_style_updated() called 2. Enter na_tray_applet_realize() 3. na_tray_applet_style_updated() called again 4. na_tray_applet_realize() calls gtk_widget_show 5. na_tray_applet_realize() returns I'm not sure exactly what is responsible for this change, after a quick google search I suspect this as the most likely candidate: https://mail.gnome.org/archives/commits-list/2012-January/msg03124.html Here is an updated patch with the ordering change you suggested. I've tested it - the bug is fixed as before.
Thanks for the investigation. Patch committed!
*** Bug 687314 has been marked as a duplicate of this bug. ***