After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690198 - Restoration of NumPad functionality is pending in Orca-xdesktop branch.
Restoration of NumPad functionality is pending in Orca-xdesktop branch.
Status: RESOLVED INVALID
Product: orca
Classification: Applications
Component: general
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: Orca Maintainers
Orca Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-14 08:14 UTC by Dattatray Bhat
Modified: 2013-01-07 00:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.29/2.30


Attachments
Fix for Flat Review taking over NumPad in orca-xdesktop. (14.05 KB, patch)
2012-12-14 09:02 UTC, Dattatray Bhat
none Details | Review

Description Dattatray Bhat 2012-12-14 08:14:25 UTC
Flat Review takes over NumPad functionality even when NumLock is on.
This problem was fixed for the main Orca branch w.e.f. Orca v3.3.4 (Bug: https://bugzilla.gnome.org/show_bug.cgi?id=628272).
But, the problem is not yet fixed for Orca xdesktop branch. I verified this with Orca 3.2.0-xdesktop.
Comment 1 Dattatray Bhat 2012-12-14 09:02:35 UTC
Created attachment 231557 [details] [review]
Fix for Flat Review taking over NumPad in orca-xdesktop. 

This patch fixes the problem of Flat Review taking over NumPad in orca-xdesktop.
It also adds the NumLock On/ Off announcements and enables key echo for the Super keys and the Menu key.
It is based on the commit
http://git.gnome.org/browse/orca/commit/?id=55d91146ba50f788610ea274214fe81c68b166e9
but has a few changes to make it work for orca-xdesktop.
Comment 2 Joanmarie Diggs (IRC: joanie) 2013-01-07 00:55:44 UTC
When I made the changes regarding the NumPad, I didn't forget to commit it to the xdesktop branch. I made a conscious decision not to include it. Had I felt it should be included, I would have done so.

The reason I made that decision is because the xdesktop branch is stable mode; it is not an unstable branch and hasn't been for quite some time now. The rule for committing things to stable branches is that the change must be high impact and low risk, which brings me to the following:

Taking over the NumPad was a design decision made by the original developers. I believe it was to address issues in AT-SPI1 and/or Solaris. The xdesktop branch works nicely with AT-SPI1 and Solaris. I would not want to break that. Including this change risks breaking that. That means it is not low risk.