After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690179 - Fix check is_callable to check for CALL not STREAMED type.
Fix check is_callable to check for CALL not STREAMED type.
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.6.x
Other Linux
: Normal major
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-12-13 21:17 UTC by Alban Browaeys
Modified: 2012-12-18 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix check is_callable to check for CALL not STREAMED type. (2.27 KB, patch)
2012-12-13 21:17 UTC, Alban Browaeys 		committed Details | Review

Description Alban Browaeys 2012-12-13 21:17:11 UTC 
Created attachment 231513 [details] [review]
Fix check is_callable to check for CALL not STREAMED type.

my build of telepathy-glib made tp_capabilities_get_channel_classes not introspectable thus not available to vala. Might be a local build issue though this lead me to check why this call was used and it turns out the caller is checking the old STREAMED type instead of CALL one. And there is a telepathy glib util function that neatly replace this section of custom code. So all in all this patch remove the offending function call and fix an old bug.


Replace custom code with "caps.supports_audio_call
(TelepathyGLib.HandleType.CONTACT)":
- fixes the non introspectable call
- removes the check on obsolete STREAMED type (all the other sources in
gnome-contacts now switched to CALL type already, expect this leftover).
Comment 1 Alexander Larsson 2012-12-18 12:11:02 UTC 
Attachment 231513 [details] pushed as 5b9052a - Fix check is_callable to check for CALL not STREAMED type.
Comment 2 Alexander Larsson 2012-12-18 12:11:23 UTC 
makes a lot of sense! thanks.