GNOME Bugzilla – Bug 690163
Add a pre-configured gio/gnetworking.h for Visual C++ builds
Last modified: 2012-12-14 16:31:19 UTC
Created attachment 231484 [details] [review] Add a preconfigured gnetworking.h(.win32) for Visual C++ builds Hi, As gio/gnetworking.h(.in) was added as a result of bug 623187, we would need a pre-configured gio/gnetworking.h(.win32) for Visual C++ builds, as those builds do not make use of autotools during the build process. This patch adds a gio/gnetworking.h.win32 to address that need, and updates the relevant build-related files. With blessings, thank you!
Comment on attachment 231484 [details] [review] Add a preconfigured gnetworking.h(.win32) for Visual C++ builds >+#include <wspiapi.h> The reason gnetworking.h is generated rather than static is because we need to check at compile time whether or not wspiapi.h is available. (And likewise another #include on the UNIX side.) Or maybe that only applies to mingw, and not Visual C? If Visual C will always have wspiapi.h, then go ahead and commit.
Hi Dan, I understood your point, hence the .win32 extension for the pre-configured gnetworking.h.win32. Yes, AFAICT wspiapi.h is shipped with the Windows SDK, which is needed (included) with a Visual C++/Studio installation. Pushed as 4b859e4e and 0b2919a9 (two patches) as git am did not like a patch that deals with files having different line endings somehow. :| With blessings, thank you!