After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690157 - wacom: allow multiple mode-switch buttons to select a given mode
wacom: allow multiple mode-switch buttons to select a given mode
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: wacom
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Olivier Fourdan
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-13 14:07 UTC by Olivier Fourdan
Modified: 2012-12-14 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (4.41 KB, patch)
2012-12-13 14:13 UTC, Olivier Fourdan
committed Details | Review

Description Olivier Fourdan 2012-12-13 14:07:46 UTC
The Cintiq 24HD has a unique LED/mode switch feature than the other tablets.

There are three modes per side, but there are also 3 different buttons to select modes. So you can go from mode 1 to mode 3 without cycling through mode 2, you just hit the individual button.

Currently, when you hit any of the mode switch buttons it just cycles through them like the other tablets do.
Comment 1 Olivier Fourdan 2012-12-13 14:13:05 UTC
Created attachment 231478 [details] [review]
Proposed patch
Comment 2 Bastien Nocera 2012-12-13 14:24:24 UTC
Review of attachment 231478 [details] [review]:

I would personally have split up that functionality into a get_button_mode/set_mode/set_next_mode, but looks good.
Comment 3 Olivier Fourdan 2012-12-14 14:05:47 UTC
Comment on attachment 231478 [details] [review]
Proposed patch

Pushed in master