Bug 690151 – [abrt] Crash in e_book_backend_file_bump_revision()

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 690151 - [abrt] Crash in e_book_backend_file_bump_revision()


Summary:	[abrt] Crash in e_book_backend_file_bump_revision()


Status:	RESOLVED FIXED

Product:	evolution-data-server
Classification:	Platform
Component:	Contacts
Version:	3.4.x (obsolete)
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	evolution-addressbook-maintainers
QA Contact:	Evolution QA team

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2012-12-13 11:17 UTC by Milan Crha
Modified:	2013-01-11 11:29 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
eds patch (2.95 KB, patch) 2013-01-11 11:22 UTC, Milan Crha	committed	Details \| Review

Description Milan Crha 2012-12-13 11:17:06 UTC

Moving this from a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=886579

Version-Release number of selected component:
evolution-data-server-3.4.4-4.fc17

Additional info:
libreport version: 2.0.18
abrt_version:   2.0.18
backtrace_rating: 4
cmdline:        /usr/libexec/evolution-addressbook-factory
crash_function: e_book_backend_file_bump_revision
kernel:         3.6.9-2.fc17.x86_64

Core was generated by `/usr/libexec/evolution-addressbook-factory'.
Program terminated with signal 6, Aborted.

+ Trace 231291

Thread 14 (Thread 0x7fa7be7fc700 (LWP 2985))

#0 fsync
at ../sysdeps/unix/syscall-template.S line 82
#1 full_fsync
at sqlite3.c line 28306
#2 unixSync
at sqlite3.c line 28398
#3 call_old_file_Sync
at e-sqlite3-vfs.c line 55
#4 sync_request_thread_cb
at e-sqlite3-vfs.c line 75
#5 g_thread_pool_thread_proxy
at gthreadpool.c line 309
#6 g_thread_proxy
at gthread.c line 801
#7 start_thread
at pthread_create.c line 309
#8 clone
at ../sysdeps/unix/sysv/linux/x86_64/clone.S line 115

Thread 13 (Thread 0x7fa7bffff700 (LWP 2983))

#0 fdatasync
at ../sysdeps/unix/syscall-template.S line 82
#1 __os_fsync
at ../../os/os_fsync.c line 92
#2 __log_flush_int
at ../../log/log_put.c line 1036
#3 __log_flush_commit
at ../../log/log_put.c line 496
#4 __log_put
at ../../log/log_put.c line 298
#5 __txn_regop_log
at ../../txn/txn_auto.c line 234
#6 __txn_commit
at ../../txn/txn.c line 656
#7 __db_put_pp
at ../../db/db_iface.c line 1581
#8 e_book_backend_file_bump_revision
at e-book-backend-file.c line 797
#9 e_book_backend_file_remove_contacts
at e-book-backend-file.c line 1086
#10 book_backend_remove_contacts
at e-book-backend-sync.c line 510
#11 operation_thread
at e-data-book.c line 177
#12 g_thread_pool_thread_proxy
at gthreadpool.c line 309
#13 g_thread_proxy
at gthread.c line 801
#14 start_thread
at pthread_create.c line 309
#15 clone
at ../sysdeps/unix/sysv/linux/x86_64/clone.S line 115

Thread 1 (Thread 0x7fa7d8ff9700 (LWP 2982))

#0 __GI_raise
at ../nptl/sysdeps/unix/sysv/linux/raise.c line 64
#1 __GI_abort
at abort.c line 91
#2 __libc_message
at ../sysdeps/unix/sysv/linux/libc_fatal.c line 198
#3 malloc_printerr
#4 _int_free
at malloc.c line 3948
#5 g_free
at gmem.c line 252
#6 e_book_backend_file_bump_revision
at e-book-backend-file.c line 792
#7 e_book_backend_file_remove_contacts
at e-book-backend-file.c line 1086
#8 book_backend_remove_contacts
at e-book-backend-sync.c line 510
#9 operation_thread
at e-data-book.c line 177
#10 g_thread_pool_thread_proxy
at gthreadpool.c line 309
#11 g_thread_proxy
at gthread.c line 801
#12 start_thread
at pthread_create.c line 309
#13 clone
at ../sysdeps/unix/sysv/linux/x86_64/clone.S line 115

Comment 1 Milan Crha 2013-01-11 11:22:30 UTC

Created attachment 233215 [details] [review]
eds patch

for evolution-data-server;

Let's guard 'priv::revision' with a mutex, as it can be changed from multiple threads simultaneously.

Comment 2 Milan Crha 2013-01-11 11:29:05 UTC

Created commit 11bc9b5 in eds master (3.7.4+)
Created commit a4027fc in eds gnome-3-6 (3.6.3+)