After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690117 - shell: fix refcounting in GMenu code
shell: fix refcounting in GMenu code
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-12-12 19:15 UTC by Giovanni Campagna
Modified: 2012-12-13 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: fix refcounting in GMenu code (1.65 KB, patch)
2012-12-12 19:15 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2012-12-12 19:15:08 UTC 
gmenu_tree_entry_get_app_info() does not return a new reference, while
gmenu_tree_get_root_directory() does.
Comment 1 Giovanni Campagna 2012-12-12 19:15:11 UTC 
Created attachment 231407 [details] [review]
shell: fix refcounting in GMenu code
Comment 2 Bastien Nocera 2012-12-13 12:07:16 UTC 
Review of attachment 231407 [details] [review]:

Please split thise in 2 separate patches. Looks good otherwise.
(I probably wouldn't have got this so wrong if there were API docs for gnome-menus).
Comment 3 Giovanni Campagna 2012-12-13 14:46:34 UTC 
Commited, thanks for the review.